Bug 185872

Summary:

Update test expectations for newly imported css-text layout tests

Product:

WebKit

Reporter:

Dawei Fenton (:realdawei) <realdawei>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Description Dawei Fenton (:realdawei) 2018-05-22 10:40:12 PDT

This bug is in reference to adding additional tests from web-platform-tests:
http://w3c-test.org/css/css-text/

The following tests were added:

imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-018.html
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-020.html
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-021.html
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html

for additional details see https://bugs.webkit.org/show_bug.cgi?id=183258

Comment 1 Dawei Fenton (:realdawei) 2018-05-22 10:48:38 PDT

CSS texts tests were imported in https://bugs.webkit.org/show_bug.cgi?id=183258

Many of them were marked failing or flaky, but these were missed:

imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-018.html
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-020.html
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-021.html
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html

Comment 2 Dawei Fenton (:realdawei) 2018-05-22 11:32:26 PDT

Created attachment 340998 [details]
Patch

Comment 3 Ryan Haddad 2018-05-22 11:38:20 PDT

Comment on attachment 340998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340998&action=review

> LayoutTests/ChangeLog:12
> +        * imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html: Added.

This list should only contain files that were changed. TestExpectations should be here, but the rest should not.

Comment 4 Dawei Fenton (:realdawei) 2018-05-22 11:44:42 PDT

Created attachment 341000 [details]
Patch

Comment 5 Ryan Haddad 2018-05-22 11:48:54 PDT

Comment on attachment 341000 [details]
Patch

Looks good!

Comment 6 WebKit Commit Bot 2018-05-22 12:16:08 PDT

Comment on attachment 341000 [details]
Patch

Clearing flags on attachment: 341000

Committed r232073: <https://trac.webkit.org/changeset/232073>

Comment 7 WebKit Commit Bot 2018-05-22 12:16:09 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Radar WebKit Bug Importer 2018-05-22 12:17:21 PDT

<rdar://problem/40459922>

Comment 9 Dawei Fenton (:realdawei) 2018-05-22 14:45:24 PDT

Add additional missed test:

imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-020.html

Comment 10 Dawei Fenton (:realdawei) 2018-05-22 15:20:13 PDT

Reopening to attach new patch.

Comment 11 Dawei Fenton (:realdawei) 2018-05-22 15:20:14 PDT

Created attachment 341036 [details]
Patch

Comment 12 Dawei Fenton (:realdawei) 2018-05-22 16:31:24 PDT

Created attachment 341046 [details]
Patch

Comment 13 WebKit Commit Bot 2018-05-22 17:12:48 PDT

Comment on attachment 341046 [details]
Patch

Clearing flags on attachment: 341046

Committed r232091: <https://trac.webkit.org/changeset/232091>

Comment 14 WebKit Commit Bot 2018-05-22 17:12:50 PDT

All reviewed patches have been landed.  Closing bug.