Bug 185872

Summary:

Update test expectations for newly imported css-text layout tests

Product:

WebKit

Reporter:

Dawei Fenton (:realdawei) <realdawei>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Dawei Fenton (:realdawei)

Reported 2018-05-22 10:40:12 PDT

This bug is in reference to adding additional tests from web-platform-tests: http://w3c-test.org/css/css-text/ The following tests were added: imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-018.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-020.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-021.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html for additional details see https://bugs.webkit.org/show_bug.cgi?id=183258

Attachments
Patch (3.75 KB, patch) 2018-05-22 11:32 PDT, Dawei Fenton (:realdawei)	no flags	Details Formatted Diff Diff
Patch (3.30 KB, patch) 2018-05-22 11:44 PDT, Dawei Fenton (:realdawei)	no flags	Details Formatted Diff Diff
Patch (2.17 KB, patch) 2018-05-22 15:20 PDT, Dawei Fenton (:realdawei)	no flags	Details Formatted Diff Diff
Patch (1.87 KB, patch) 2018-05-22 16:31 PDT, Dawei Fenton (:realdawei)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dawei Fenton (:realdawei)

Comment 1 2018-05-22 10:48:38 PDT

CSS texts tests were imported in https://bugs.webkit.org/show_bug.cgi?id=183258 Many of them were marked failing or flaky, but these were missed: imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-018.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-020.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-021.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html

Dawei Fenton (:realdawei)

Comment 2 2018-05-22 11:32:26 PDT

Created attachment 340998 [details] Patch

Ryan Haddad

Comment 3 2018-05-22 11:38:20 PDT

Comment on attachment 340998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340998&action=review > LayoutTests/ChangeLog:12 > + * imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html: Added. This list should only contain files that were changed. TestExpectations should be here, but the rest should not.

Dawei Fenton (:realdawei)

Comment 4 2018-05-22 11:44:42 PDT

Created attachment 341000 [details] Patch

Ryan Haddad

Comment 5 2018-05-22 11:48:54 PDT

Comment on attachment 341000 [details] Patch Looks good!

WebKit Commit Bot

Comment 6 2018-05-22 12:16:08 PDT

Comment on attachment 341000 [details] Patch Clearing flags on attachment: 341000 Committed r232073: <https://trac.webkit.org/changeset/232073>

WebKit Commit Bot

Comment 7 2018-05-22 12:16:09 PDT

All reviewed patches have been landed. Closing bug.