RESOLVED FIXED 185872
Update test expectations for newly imported css-text layout tests 
https://bugs.webkit.org/show_bug.cgi?id=185872
Summary Update test expectations for newly imported css-text layout tests
Dawei Fenton (:realdawei)
Reported 2018-05-22 10:40:12 PDT
This bug is in reference to adding additional tests from web-platform-tests: http://w3c-test.org/css/css-text/ The following tests were added: imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-018.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-020.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-021.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html for additional details see https://bugs.webkit.org/show_bug.cgi?id=183258
Attachments
Patch (3.75 KB, patch)
2018-05-22 11:32 PDT, Dawei Fenton (:realdawei) 		no flags
DetailsFormatted DiffDiff
Patch (3.30 KB, patch)
2018-05-22 11:44 PDT, Dawei Fenton (:realdawei) 		no flags
DetailsFormatted DiffDiff
Patch (2.17 KB, patch)
2018-05-22 15:20 PDT, Dawei Fenton (:realdawei) 		no flags
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2018-05-22 16:31 PDT, Dawei Fenton (:realdawei) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dawei Fenton (:realdawei)
Comment 1 2018-05-22 10:48:38 PDT
CSS texts tests were imported in https://bugs.webkit.org/show_bug.cgi?id=183258 Many of them were marked failing or flaky, but these were missed: imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-018.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-020.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-021.html imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html
Dawei Fenton (:realdawei)
Comment 2 2018-05-22 11:32:26 PDT
Created attachment 340998 [details] Patch
Ryan Haddad
Comment 3 2018-05-22 11:38:20 PDT
Comment on attachment 340998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340998&action=review > LayoutTests/ChangeLog:12 > + * imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-103.html: Added. This list should only contain files that were changed. TestExpectations should be here, but the rest should not.
Dawei Fenton (:realdawei)
Comment 4 2018-05-22 11:44:42 PDT
Created attachment 341000 [details] Patch
Ryan Haddad
Comment 5 2018-05-22 11:48:54 PDT
Comment on attachment 341000 [details] Patch Looks good!
WebKit Commit Bot
Comment 6 2018-05-22 12:16:08 PDT
Comment on attachment 341000 [details] Patch Clearing flags on attachment: 341000 Committed r232073: <https://trac.webkit.org/changeset/232073>
WebKit Commit Bot
Comment 7 2018-05-22 12:16:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-05-22 12:17:21 PDT
<rdar://problem/40459922>
Dawei Fenton (:realdawei)
Comment 9 2018-05-22 14:45:24 PDT
Add additional missed test: imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-020.html
Dawei Fenton (:realdawei)
Comment 10 2018-05-22 15:20:13 PDT
Reopening to attach new patch.
Dawei Fenton (:realdawei)
Comment 11 2018-05-22 15:20:14 PDT
Created attachment 341036 [details] Patch
Dawei Fenton (:realdawei)
Comment 12 2018-05-22 16:31:24 PDT
Created attachment 341046 [details] Patch
WebKit Commit Bot
Comment 13 2018-05-22 17:12:48 PDT
Comment on attachment 341046 [details] Patch Clearing flags on attachment: 341046 Committed r232091: <https://trac.webkit.org/changeset/232091>
WebKit Commit Bot
Comment 14 2018-05-22 17:12:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.