Bug 183258 – [css-text] Import WPT test suite

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Manuel Rego Casasnovas]

This bug is about importing the following test suite from web-platform-tests:
http://w3c-test.org/css/css-text/

[Manuel Rego Casasnovas]

Created attachment 334846 [details]
Patch

[EWS Watchlist]

Comment on attachment 334846 [details]
Patch

Attachment 334846 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6725905

New failing tests:
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-028.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-001.html
imported/w3c/web-platform-tests/css/css-text/white-space/white-space-collapse-002.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-017.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-004.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-059.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-006.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-159.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-259.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-016.html

[EWS Watchlist]

Created attachment 334860 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Created attachment 334861 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 334846 [details]
Patch

Attachment 334846 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6726260

New failing tests:
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-028.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-001.html
imported/w3c/web-platform-tests/css/css-text/white-space/white-space-collapse-002.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-017.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-004.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-059.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-006.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-159.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-259.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-016.html

[EWS Watchlist]

Created attachment 334867 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 334846 [details]
Patch

Attachment 334846 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6726984

New failing tests:
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-028.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-001.html
imported/w3c/web-platform-tests/css/css-text/white-space/white-space-collapse-002.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-017.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-004.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-059.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-006.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-159.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-259.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-016.html

[EWS Watchlist]

Created attachment 334873 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 334846 [details]
Patch

Attachment 334846 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6727486

New failing tests:
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-028.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-001.html
imported/w3c/web-platform-tests/css/css-text/white-space/white-space-collapse-002.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-017.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-004.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-059.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-006.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-159.html
imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-259.html
imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-016.html

[EWS Watchlist]

Created attachment 334876 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Manuel Rego Casasnovas]

Created attachment 335000 [details]
Patch

[EWS Watchlist]

Comment on attachment 335000 [details]
Patch

Attachment 335000 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6813283

New failing tests:
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-003.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-001.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-011.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-007.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-009.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-002.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-004.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-005.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ko-000.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-006.html

[EWS Watchlist]

Created attachment 335002 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335000 [details]
Patch

Attachment 335000 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6814035

New failing tests:
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-003.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-001.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-006.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-007.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-009.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ko-000.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-004.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-005.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-002.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-011.html

[EWS Watchlist]

Created attachment 335007 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Manuel Rego Casasnovas]

Created attachment 335075 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 335075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335075&action=review

How much extra time do these new tests require? Will we need to increase the number of bots we run?

> LayoutTests/TestExpectations:1727


Just curious why you imported the failing tests, too.

[youenn fablet]

> Just curious why you imported the failing tests, too.

I guess the plan is to fix those?
In general, I prefer that we import everything in a folder, that is simpler.

[Manuel Rego Casasnovas]

(In reply to Myles C. Maxfield from comment #17)
> How much extra time do these new tests require? Will we need to increase the
> number of bots we run?

They are 820 new tests, they take 3 minutes in my machine.
Actually some tests have been recently removed as they were outdated,
so the number will be smaller but probably over 700.
I need to update the patch.

(In reply to youenn fablet from comment #18)
> > Just curious why you imported the failing tests, too.
> 
> I guess the plan is to fix those?

We're planing to work on some of them, for example bug #177327.

> In general, I prefer that we import everything in a folder, that is simpler.

Yes, I thought that was the policy importing the whole test suite
and having some results some failures and some passes that can be used
to detect regressions/progressions with new changes.

We thought it would be better to import the test suite
(that will be shared with other browsers)
so we don't have to write new tests from scratch.
If you prefer a different policy like only importing a few tests
related to the bugs we're working on or something like that please tell us.

[Manuel Rego Casasnovas]

Created attachment 340491 [details]
Patch

[EWS Watchlist]

Attachment 340491 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1633 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 340491 [details]
Patch

Attachment 340491 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7698599

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340494 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340491 [details]
Patch

Attachment 340491 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7698625

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340495 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340491 [details]
Patch

Attachment 340491 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7698510

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340496 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 340491 [details]
Patch

Attachment 340491 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7699336

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340502 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Manuel Rego Casasnovas]

Created attachment 340521 [details]
Patch

[EWS Watchlist]

Comment on attachment 340521 [details]
Patch

Attachment 340521 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7702089

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340532 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Manuel Rego Casasnovas]

Created attachment 340831 [details]
Patch

[EWS Watchlist]

Comment on attachment 340831 [details]
Patch

Attachment 340831 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7750777

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340834 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340831 [details]
Patch

Attachment 340831 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7750782

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340836 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340831 [details]
Patch

Attachment 340831 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7750702

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340837 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 340831 [details]
Patch

Attachment 340831 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7750780

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340838 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Manuel Rego Casasnovas]

Created attachment 340840 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 340842 [details]
Patch

[EWS Watchlist]

Comment on attachment 340842 [details]
Patch

Attachment 340842 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7752091

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340845 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340842 [details]
Patch

Attachment 340842 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7752102

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340847 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340842 [details]
Patch

Attachment 340842 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7752045

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340849 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 340842 [details]
Patch

Attachment 340842 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7752099

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 340851 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Manuel Rego Casasnovas]

Created attachment 340896 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 340896 [details]
Patch

Clearing flags on attachment: 340896

Committed r232057: <https://trac.webkit.org/changeset/232057>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40444444>