Bug 185866

Summary:

[GTK] WebDriver: implement AutomationSessionClient::didDisconnectFromRemote

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, berto, bugs-noreply, ews-watchlist, gustavo, mcatanzaro

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=185867

Attachments:

Description	Flags
Patch	bburg: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews201 for win-future	none

Carlos Garcia Campos

Reported 2018-05-22 05:44:12 PDT

To handle the case of the session being closed by the browser, for example in case of a network process crash. This is currently causing WebDriver tests to timeout in the bot.

Attachments
Patch (4.42 KB, patch) 2018-05-22 06:03 PDT, Carlos Garcia Campos	bburg: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews201 for win-future (12.74 MB, application/zip) 2018-05-22 07:49 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2018-05-22 06:03:52 PDT

Created attachment 340978 [details] Patch

EWS Watchlist

Comment 2 2018-05-22 06:04:39 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

EWS Watchlist

Comment 3 2018-05-22 07:49:03 PDT

Comment on attachment 340978 [details] Patch Attachment 340978 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7765003 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

EWS Watchlist

Comment 4 2018-05-22 07:49:15 PDT

Created attachment 340982 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Blaze Burg

Comment 5 2018-05-22 13:13:37 PDT

Comment on attachment 340978 [details] Patch r=me, though you may want to consult a GTK reviewer as well.

Michael Catanzaro

Comment 6 2018-05-23 07:59:32 PDT

Comment on attachment 340978 [details] Patch GTK changes are fine.

Carlos Garcia Campos

Comment 7 2018-05-23 08:25:11 PDT

Committed r232111: <https://trac.webkit.org/changeset/232111>

Note You need to log in before you can comment on or make changes to this bug.