Bug 185805

Summary:

Update CSSOM WPT tests.

Product:

WebKit

Reporter:

Emilio Cobos Álvarez (:emilio) <emilio>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, fred.wang, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=179391

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews114 for mac-sierra	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch for landing	none
Patch for landing	none

Emilio Cobos Álvarez (:emilio)

Reported 2018-05-20 11:17:49 PDT

They're quite old.

Attachments
Patch (764.92 KB, patch) 2018-05-20 11:26 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.24 MB, application/zip) 2018-05-20 12:38 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.66 MB, application/zip) 2018-05-20 12:44 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (2.95 MB, application/zip) 2018-05-20 13:05 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.22 MB, application/zip) 2018-05-20 13:18 PDT, EWS Watchlist	no flags	Details
Patch for landing (764.91 KB, patch) 2018-05-20 13:19 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Patch for landing (764.92 KB, patch) 2018-05-20 13:43 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Emilio Cobos Álvarez (:emilio)

Comment 1 2018-05-20 11:26:16 PDT

Created attachment 340795 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 2 2018-05-20 12:12:27 PDT

Comment on attachment 340795 [details] Patch Thanks for the review Fred!

EWS Watchlist

Comment 3 2018-05-20 12:38:55 PDT

Comment on attachment 340795 [details] Patch Attachment 340795 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7745644 New failing tests: imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

EWS Watchlist

Comment 4 2018-05-20 12:38:56 PDT

Created attachment 340798 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-05-20 12:44:54 PDT

Comment on attachment 340795 [details] Patch Attachment 340795 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7745653 New failing tests: imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

EWS Watchlist

Comment 6 2018-05-20 12:44:56 PDT

Created attachment 340799 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-05-20 13:05:21 PDT

Comment on attachment 340795 [details] Patch Attachment 340795 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7745683 New failing tests: imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

EWS Watchlist

Comment 8 2018-05-20 13:05:23 PDT

Created attachment 340800 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-05-20 13:18:51 PDT

Comment on attachment 340795 [details] Patch Attachment 340795 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7745696 New failing tests: imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

EWS Watchlist

Comment 10 2018-05-20 13:18:52 PDT

Created attachment 340802 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Emilio Cobos Álvarez (:emilio)

Comment 11 2018-05-20 13:19:25 PDT

Created attachment 340803 [details] Patch for landing

Emilio Cobos Álvarez (:emilio)

Comment 12 2018-05-20 13:20:49 PDT

Submitted a test change upstream to avoid printing the number of properties in the expectation. https://github.com/w3c/web-platform-tests/pull/11083

WebKit Commit Bot

Comment 13 2018-05-20 13:29:56 PDT

Comment on attachment 340803 [details] Patch for landing Rejecting attachment 340803 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 340803, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Frederic Wang found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/7746061

Emilio Cobos Álvarez (:emilio)

Comment 14 2018-05-20 13:42:29 PDT

Sigh, unicode :)

Emilio Cobos Álvarez (:emilio)

Comment 15 2018-05-20 13:43:04 PDT

Created attachment 340804 [details] Patch for landing

WebKit Commit Bot

Comment 16 2018-05-20 14:41:15 PDT

Comment on attachment 340804 [details] Patch for landing Clearing flags on attachment: 340804 Committed r232005: <https://trac.webkit.org/changeset/232005>

WebKit Commit Bot

Comment 17 2018-05-20 14:41:17 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2018-05-20 14:42:30 PDT

<rdar://problem/40402665>

Note You need to log in before you can comment on or make changes to this bug.