Bug 185586

Summary: Disable pointer poisoning
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, ryanhaddad, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ysuzuki: review+

Description Filip Pizlo 2018-05-13 11:02:21 PDT 
It seems to possibly be a small speed-up.  I want to see if the bots agree.
Comment 1 Filip Pizlo 2018-05-13 11:03:24 PDT 
Created attachment 340268 [details]
the patch
Comment 2 Yusuke Suzuki 2018-05-13 11:06:04 PDT 
Comment on attachment 340268 [details]
the patch

r=me. BTW, do you plan to remove this functionality? I have a patch for Windows 64bit poisoning right now (https://bugs.webkit.org/show_bug.cgi?id=185421). If it will be removed soon, I'll make that patch WONTFIX.
Comment 3 Filip Pizlo 2018-05-13 11:56:35 PDT 
(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 340268 [details]
> the patch
> 
> r=me. BTW, do you plan to remove this functionality? I have a patch for
> Windows 64bit poisoning right now
> (https://bugs.webkit.org/show_bug.cgi?id=185421). If it will be removed
> soon, I'll make that patch WONTFIX.

I think that if it's a confirmed speed-up then we will remove it.
Comment 4 Filip Pizlo 2018-05-13 11:57:21 PDT 
Landed in https://trac.webkit.org/changeset/231743/webkit
Comment 5 Radar WebKit Bug Importer 2018-05-13 11:58:18 PDT 
<rdar://problem/40202974>
Comment 6 Ryan Haddad 2018-05-14 15:39:13 PDT 
I suppose this may be expected, but this caused some API tests to timeout:

Timeout
    TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Assignment
    TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Basic
    TestWTF.WTF_PoisonedUniquePtr.Assignment
    TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Swap
    TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.ReturnValue
    TestWTF.WTF_Poisoned.Assignment
    TestWTF.WTF_PoisonedUniquePtr.Swap
    TestWTF.WTF_Poisoned.ReturnValue
    TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.ReturnValue
    TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Basic
    TestWTF.WTF_PoisonedUniquePtr.Basic
    TestWTF.WTF_Poisoned.Swap
    TestWTF.WTF_Poisoned.Basic
    TestWTF.WTF_PoisonedUniquePtr.ReturnValue
    TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Assignment
    TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Swap

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4487
Comment 7 Ryan Haddad 2018-05-14 16:16:35 PDT 
Disabled API tests in https://trac.webkit.org/r231774