Bug 185464 – [MIPS] Use mfhc1 and mthc1 to fix assembler error

• Component: New Bugs
• Status: RESOLVED FIXED

[Dominik Inführ]

[MIPS] Use mfhc1 and mthc1 to fix assembler error

[Dominik Inführ]

Created attachment 339930 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 339930 [details]
Patch

Rejecting attachment 339930 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 339930, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 4dd5f054ca0fd1facf03faceff772d7f02351f71 5d2ee099462e6ac44ce4a6829a77d3db3d944b92 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/7620528

[WebKit Commit Bot]

Comment on attachment 339930 [details]
Patch

Clearing flags on attachment: 339930

Committed r231552: <https://trac.webkit.org/changeset/231552>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40086712>

[Loïc Yhuel]

This change breaks the build on MIPS32r1 (which doesn't support mfhc1 and mthc1).

I assume the assembler error was on a -mfpxx or -mfp64 target, which runs (or should be able to run for -mfpxx) with FR=1 (f0..f31 are independent 64 bit registers).

The original code is fine with -mfp32, running with FR=0 (f0..f31 are 32 bit registers, instructions operating on double use two even+odd register), which is the only mode supported on MIPS32r1.

https://dmz-portal.mips.com/wiki/MIPS_O32_ABI_-_FR0_and_FR1_Interlinking

[Dominik Inführ]

I've tried to fix that in https://bugs.webkit.org/show_bug.cgi?id=185944. What do you think?