Bug 185232

Summary: [Win] Use C++17 in MSVC
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, darin, dbates, don.olmstead, ews-watchlist, mcatanzaro, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191101
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews200 for win-future
none
Patch
none
Archive of layout-test-results from ews200 for win-future
none
Archive of layout-test-results from ews201 for win-future
none
Patch achristensen: review+

Description Yusuke Suzuki 2018-05-02 18:28:36 PDT 
[Win] Use C++17 in MSVC
Comment 1 Yusuke Suzuki 2018-05-02 18:28:58 PDT 
Created attachment 339374 [details]
Patch
Comment 2 Yusuke Suzuki 2018-05-02 18:37:24 PDT 
Created attachment 339375 [details]
Patch
Comment 3 Yusuke Suzuki 2018-05-02 19:30:22 PDT 
Created attachment 339378 [details]
Patch
Comment 4 Yusuke Suzuki 2018-05-02 21:49:24 PDT 
Created attachment 339386 [details]
Patch
Comment 5 EWS Watchlist 2018-05-02 21:52:06 PDT 
Attachment 339386 [details] did not pass style-queue:


ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 23 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Yusuke Suzuki 2018-05-03 00:23:40 PDT 
Created attachment 339395 [details]
Patch
Comment 7 EWS Watchlist 2018-05-03 00:25:34 PDT 
Attachment 339395 [details] did not pass style-queue:


ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 23 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Yusuke Suzuki 2018-05-03 02:10:57 PDT 
Created attachment 339400 [details]
Patch
Comment 9 EWS Watchlist 2018-05-03 02:12:08 PDT 
Attachment 339400 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 24 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Yusuke Suzuki 2018-05-03 18:09:21 PDT 
Created attachment 339499 [details]
Patch
Comment 11 EWS Watchlist 2018-05-03 18:12:36 PDT 
Attachment 339499 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 24 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Yusuke Suzuki 2018-05-06 01:40:40 PDT 
Created attachment 339675 [details]
Patch
Comment 13 EWS Watchlist 2018-05-06 01:43:56 PDT 
Attachment 339675 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/TextInputController.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 25 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Yusuke Suzuki 2018-05-06 02:20:41 PDT 
Created attachment 339677 [details]
Patch
Comment 15 EWS Watchlist 2018-05-06 02:22:16 PDT 
Attachment 339677 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/TextInputController.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 25 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Yusuke Suzuki 2018-05-06 02:25:41 PDT 
Created attachment 339678 [details]
Patch
Comment 17 EWS Watchlist 2018-05-06 02:27:29 PDT 
Attachment 339678 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/TextInputController.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 25 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 Yusuke Suzuki 2018-05-06 03:07:33 PDT 
OK, windows bots are green :D Ready for review.
Comment 19 EWS Watchlist 2018-05-06 04:26:30 PDT 
Comment on attachment 339678 [details]
Patch

Attachment 339678 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7584623

New failing tests:
webanimations/opacity-animation-no-longer-composited-upon-completion.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html
http/tests/security/contentSecurityPolicy/script-src-redirect.html
webanimations/css-animations.html
webanimations/width-and-opacity-separate-animation-yields-no-compositing.html
Comment 20 EWS Watchlist 2018-05-06 04:26:41 PDT 
Created attachment 339679 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 21 Yusuke Suzuki 2018-05-06 05:12:05 PDT 
Created attachment 339680 [details]
Patch
Comment 22 EWS Watchlist 2018-05-06 05:14:07 PDT 
Attachment 339680 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/TextInputController.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 25 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 23 EWS Watchlist 2018-05-06 07:16:02 PDT 
Comment on attachment 339680 [details]
Patch

Attachment 339680 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7585570

New failing tests:
http/tests/security/contentSecurityPolicy/script-src-redirect.html
webanimations/css-animations.html
webanimations/opacity-animation-no-longer-composited-upon-completion.html
webanimations/width-and-opacity-separate-animation-yields-no-compositing.html
http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html
Comment 24 EWS Watchlist 2018-05-06 07:16:14 PDT 
Created attachment 339682 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 25 EWS Watchlist 2018-05-06 09:27:42 PDT 
Comment on attachment 339680 [details]
Patch

Attachment 339680 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7586223

New failing tests:
http/tests/security/contentSecurityPolicy/script-src-redirect.html
webanimations/css-animations.html
webanimations/opacity-animation-no-longer-composited-upon-completion.html
webanimations/width-and-opacity-separate-animation-yields-no-compositing.html
http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html
Comment 26 EWS Watchlist 2018-05-06 09:27:53 PDT 
Created attachment 339685 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 27 Darin Adler 2018-05-06 22:56:26 PDT 
Any theories on why the tests are failing?
Comment 28 Yusuke Suzuki 2018-05-07 01:43:38 PDT 
(In reply to Darin Adler from comment #27)
> Any theories on why the tests are failing?

Several theories can be considered, but it is quite difficult to investigate the reason without the actual environment.
Can any AppleWin maintainers check the crashes?

1. std::optional use is wrong

If the existing code uses std::optional wrongly, it causes a bug when we switch std::optional from our own one to MSVC's one.

2. std::optional in MSVC is wrong

If MSVC's std::optional implementation has a bug, it causes a bug.

3. MSVC C++17 implementation has a bug

If MSVC has a bug when using C++17, it causes a bug.

4. std::optional's ABI compatibility with the existing Windows support library

If some of Windows support libraries use std::optional for their API, we need to rebuild it when switching std::optional from our own one to MSVC's one.
Comment 29 Don Olmstead 2018-05-07 14:10:14 PDT 
(In reply to Yusuke Suzuki from comment #28)
> (In reply to Darin Adler from comment #27)
> > Any theories on why the tests are failing?
> 
> Several theories can be considered, but it is quite difficult to investigate
> the reason without the actual environment.
> Can any AppleWin maintainers check the crashes?
> 
> 1. std::optional use is wrong
> 
> If the existing code uses std::optional wrongly, it causes a bug when we
> switch std::optional from our own one to MSVC's one.
> 
> 2. std::optional in MSVC is wrong
> 
> If MSVC's std::optional implementation has a bug, it causes a bug.
> 
> 3. MSVC C++17 implementation has a bug
> 
> If MSVC has a bug when using C++17, it causes a bug.
> 
> 4. std::optional's ABI compatibility with the existing Windows support
> library
> 
> If some of Windows support libraries use std::optional for their API, we
> need to rebuild it when switching std::optional from our own one to MSVC's
> one.

A new version of VS 2017 dropped today https://blogs.msdn.microsoft.com/visualstudio/2018/05/07/visual-studio-2017-version-15-7-and-version-15-8-preview-1/ so if its 3. it might be worth looking at it after the update.
Comment 30 Michael Catanzaro 2018-05-08 19:07:39 PDT 
It's pretty weird that std::optional is causing us such a huge amount of trouble in so many bugs.
Comment 31 Don Olmstead 2018-05-11 12:16:41 PDT 
Comment on attachment 339680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339680&action=review

Can someone on the Apple side verify what version of MSVC their bots are on? The latest version 15.7 has a lot more C++17 conformance.

> Source/WTF/wtf/StdLibExtras.h:546
> +#if __cplusplus < 201703L && (!defined(_MSC_FULL_VER) || _MSC_FULL_VER < 190023918)

It looks like we can technically get rid of the MSVS checks here https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly-reports-__cplusplus/
Comment 32 Alex Christensen 2018-05-11 12:47:58 PDT 
Comment on attachment 339680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339680&action=review

> Source/WTF/wtf/Optional.h:51
> -#if !COMPILER(MSVC) && !PLATFORM(COCOA) && __has_include(<optional>)
> +#if !PLATFORM(COCOA) && __has_include(<optional>)
>  # include <optional>

If std::optional is causing us so many problems, we could probably land everything but this, then do the std::optional change in a follow-up patch.
Comment 33 Yusuke Suzuki 2018-05-14 11:38:26 PDT 
(In reply to Alex Christensen from comment #32)
> Comment on attachment 339680 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339680&action=review
> 
> > Source/WTF/wtf/Optional.h:51
> > -#if !COMPILER(MSVC) && !PLATFORM(COCOA) && __has_include(<optional>)
> > +#if !PLATFORM(COCOA) && __has_include(<optional>)
> >  # include <optional>
> 
> If std::optional is causing us so many problems, we could probably land
> everything but this, then do the std::optional change in a follow-up patch.

The problematic thing is that we are not sure whether std::optional is an actual problem... And I'm not sure we can compile it without using system std::optional: for example it redefines std::optional if some system header includes <optional> internally. Anyway, I'll try it :)
Comment 34 Yusuke Suzuki 2018-05-14 11:43:08 PDT 
Created attachment 340336 [details]
Patch
Comment 35 EWS Watchlist 2018-05-14 11:45:25 PDT 
Attachment 340336 [details] did not pass style-queue:


ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/DumpRenderTree/win/TextInputController.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 25 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 36 Yusuke Suzuki 2018-05-16 01:39:58 PDT 
Seeing the log in AppleWin, this patch now works well. We do not use std::optional in MSVC right now. Ready for reviews :)


(In reply to Don Olmstead from comment #31)
> Comment on attachment 339680 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339680&action=review
> 
> Can someone on the Apple side verify what version of MSVC their bots are on?
> The latest version 15.7 has a lot more C++17 conformance.

Can we do this?

> 
> > Source/WTF/wtf/StdLibExtras.h:546
> > +#if __cplusplus < 201703L && (!defined(_MSC_FULL_VER) || _MSC_FULL_VER < 190023918)
> 
> It looks like we can technically get rid of the MSVS checks here
> https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly-
> reports-__cplusplus/

Once MSVC is updated, we will use this and remove these checks!
Comment 37 Yusuke Suzuki 2018-05-16 10:50:45 PDT 
Committed r231852: <https://trac.webkit.org/changeset/231852>
Comment 38 Radar WebKit Bug Importer 2018-05-16 10:53:55 PDT 
<rdar://problem/40299634>