Bug 185061

Summary: REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184982
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2018-04-26 17:34:44 PDT
After https://trac.webkit.org/changeset/231039, the RunUnitTests step reports 13 test failures even though none actually failed. This is because it is comparing the total number of tests to the number that passed without taking into account those that are disabled. See: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/4950
Attachments
Patch (2.75 KB, patch)
2018-04-26 17:43 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-04-26 17:43:44 PDT
Created attachment 338942 [details] Patch
Ryan Haddad
Comment 2 2018-04-26 17:46:51 PDT
Comment on attachment 338942 [details] Patch Thanks, Aakash!
WebKit Commit Bot
Comment 3 2018-04-26 18:25:16 PDT
Comment on attachment 338942 [details] Patch Clearing flags on attachment: 338942 Committed r231083: <https://trac.webkit.org/changeset/231083>
WebKit Commit Bot
Comment 4 2018-04-26 18:25:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-04-26 18:26:19 PDT
<rdar://problem/39778914>
Note You need to log in before you can comment on or make changes to this bug.