Bug 184982

Summary: REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181043
https://bugs.webkit.org/show_bug.cgi?id=185061
Attachments:
Description Flags
Patch
none
Patch for landing none

Ryan Haddad
Reported 2018-04-25 11:10:53 PDT
After https://trac.webkit.org/changeset/230998/webkit, the bot watcher's dashboard no longer displays the number of API tests that failed, displaying "api test failed" instead of "1 api test failure" The status for the run-api-tests step no longer displays the number of failures, as seen below Test run with API test failure before r230998: "1 unit test failed or timed out " https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/9731 Test run with API test failure after r230998: "run-api-tests" https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/9732
Attachments
Patch (13.36 KB, patch)
2018-04-25 16:36 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.37 KB, patch)
2018-04-25 16:46 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-04-25 11:45:40 PDT
Looks like we need to update the regex in Tools/BuildSlaveSupport/build.webkit.org-config/steps.py for RunUnitTests.
Jonathan Bedard
Comment 2 2018-04-25 16:36:10 PDT
Created attachment 338822 [details] Patch
Aakash Jain
Comment 3 2018-04-25 16:40:26 PDT
rs=me
Jonathan Bedard
Comment 4 2018-04-25 16:46:01 PDT
Created attachment 338824 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-04-25 19:11:04 PDT
Comment on attachment 338824 [details] Patch for landing Clearing flags on attachment: 338824 Committed r231039: <https://trac.webkit.org/changeset/231039>
WebKit Commit Bot
Comment 6 2018-04-25 19:11:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-25 19:13:10 PDT
<rdar://problem/39744413>
Note You need to log in before you can comment on or make changes to this bug.