Summary: | SVG animation flickers when restarting | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abecsi, felician, krit, webkit.review.bot, zimmermann | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
URL: | http://mcc.id.au/temp/2008/anim-flicker.svg | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 41761 | ||||||||||||
Attachments: |
|
Description
Cameron McCormack (:heycam)
2008-04-12 19:08:48 PDT
I can confirm this, it also accours on qt-linux. Created attachment 97110 [details]
Patch for SVG animation flickers when restarting
Comment on attachment 97110 [details] Patch for SVG animation flickers when restarting View in context: https://bugs.webkit.org/attachment.cgi?id=97110&action=review > Source/WebCore/ChangeLog:8 > + This change eliminates the flickering when SVG animation restarting. This is not a sufficient ChangeLog. Please explain what your patch is doing and why. :-) Created attachment 97126 [details]
Patch for SVG animation flickers when restarting
Dirk, do you think this patch is reasonable as-is? Comment on attachment 97126 [details]
Patch for SVG animation flickers when restarting
Patch looks great! We need regression tests for changes like that. Sadly I don't know a way how to test. Maybe with SVGSVGElements getCurrentTime()? Can you check this? Anyway, even if there is no way to test it, this needs to be noted in the changelog. But please try to find a way first.
Created attachment 98691 [details]
Patch for SVG animation flickers when restarting
I think there is no way to tests SVG flickering. I noted it in the ChangeLog.
Comment on attachment 98691 [details] Patch for SVG animation flickers when restarting View in context: https://bugs.webkit.org/attachment.cgi?id=98691&action=review Looks good to me, you forgot to ask for review, though - can you upload a new one that I can r+ and cq+ ? > Source/WebCore/ChangeLog:18 > + The following methods just modified for standardization: s/standardization/consistency/. > Source/WebCore/ChangeLog:22 > + No new tests, because currently there is no way to test SVG flickering at zero time. One space too much. The latest patch is incorrect. Thats why I marked it to obsolate. (In reply to comment #9) > The latest patch is incorrect. Thats why I marked it to obsolate. The patch is ok. There was some problem with my repo. Created attachment 98869 [details]
Patch for SVG animation flickers when restarting
Only spelling and spacing fixed according to the prev patch.
Comment on attachment 98869 [details]
Patch for SVG animation flickers when restarting
r=me!
Comment on attachment 98869 [details] Patch for SVG animation flickers when restarting Clearing flags on attachment: 98869 Committed r89907: <http://trac.webkit.org/changeset/89907> All reviewed patches have been landed. Closing bug. |