Summary: | [WPE] Use GNU install directories | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WPE WebKit | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 178894 | ||||||
Attachments: |
|
Description
Michael Catanzaro
2018-04-06 17:51:33 PDT
Created attachment 337438 [details]
Patch
The changes introduced by the patch are indeed the correct thing to do. I am in favor of landing this :-) I'll fix GTK before landing I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which was requested, unless somebody objects. Comment on attachment 337438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337438&action=review > Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44 > + return String(); return { }; (In reply to Michael Catanzaro from comment #4) > I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which > was requested, unless somebody objects. Actually this isn't really needed. (In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 337438 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337438&action=review > > > Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44 > > + return String(); > > return { }; OK. Committed r230429: <https://trac.webkit.org/changeset/230429> *** Bug 178956 has been marked as a duplicate of this bug. *** |