Bug 184337

Summary:

WebContent process is calling CGDisplayUsesInvertedPolarity

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, pvollan, rniwa, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

184322, 185515

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch for landing	bfulgham: commit-queue-

Description Brent Fulgham 2018-04-05 12:22:42 PDT

We need to broker access to CGDisplayUsesInvertedPolarity so that the WebContent process doesn't need to use it.

We already pass other screen-related values as part of ScreenProperties. We just need to add 'inverted color' status to this as well to avoid interacting with the NSDisplay in the WebContent process.

Comment 1 Radar WebKit Bug Importer 2018-04-05 12:23:19 PDT

<rdar://problem/39215702>

Comment 2 Brent Fulgham 2018-04-05 16:30:30 PDT

This is also happening for CGDisplayUsesForceToGray.

Comment 3 Brent Fulgham 2018-04-05 16:38:39 PDT

Created attachment 337309 [details]
Patch

Comment 4 Brent Fulgham 2018-04-05 17:03:41 PDT

Created attachment 337314 [details]
Patch

Comment 5 EWS Watchlist 2018-04-05 18:14:11 PDT

Comment on attachment 337314 [details]
Patch

Attachment 337314 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7220796

Number of test failures exceeded the failure limit.

Comment 6 EWS Watchlist 2018-04-05 18:14:12 PDT

Created attachment 337320 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 7 Brent Fulgham 2018-04-05 19:50:47 PDT

Created attachment 337331 [details]
Patch

Comment 8 EWS Watchlist 2018-04-05 20:53:03 PDT

Comment on attachment 337331 [details]
Patch

Attachment 337331 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7222220

Number of test failures exceeded the failure limit.

Comment 9 EWS Watchlist 2018-04-05 20:53:04 PDT

Created attachment 337339 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 10 Brent Fulgham 2018-04-05 20:58:28 PDT

Created attachment 337340 [details]
Patch for landing

Comment 11 Brent Fulgham 2018-04-05 21:44:35 PDT

Committed r230323: <https://trac.webkit.org/changeset/230323>

Comment 12 Brent Fulgham 2018-04-06 09:09:01 PDT

Follow-up fix landed in r230331: <https://trac.webkit.org/changeset/230331/webkit>

Comment 13 Brent Fulgham 2018-04-06 12:45:00 PDT

Another follow-up landed in r230352: <https://trac.webkit.org/changeset/230352/webkit>