Bug 184302

Summary: Start migration to a version of contentsToRootView() that may take scroll offset into account for delegated scrolling
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ews-watchlist, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=182785
Bug Depends on:    
Bug Blocks: 184297    
Attachments:
Description Flags
Patch for EWS
none
Archive of layout-test-results from ews206 for win-future
none
Patch
none
Patch
none
Patch
none
Patch none

Description Frédéric Wang (:fredw) 2018-04-04 07:33:27 PDT 
Created attachment 337167 [details]
Patch for EWS

This is similar to bug 182785 but to prepare for bug 184297.
Comment 1 EWS Watchlist 2018-04-04 10:57:55 PDT 
Comment on attachment 337167 [details]
Patch for EWS

Attachment 337167 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7205354

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 2 EWS Watchlist 2018-04-04 10:58:06 PDT 
Created attachment 337192 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 3 Frédéric Wang (:fredw) 2018-04-04 12:05:45 PDT 
Created attachment 337200 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2018-04-05 01:48:47 PDT 
Created attachment 337258 [details]
Patch
Comment 5 Frédéric Wang (:fredw) 2018-04-05 01:51:58 PDT 
Comment on attachment 337258 [details]
Patch

Wrong bug.
Comment 6 Frédéric Wang (:fredw) 2018-07-11 06:40:49 PDT 
Created attachment 344763 [details]
Patch

Rebasing...
Comment 7 Frédéric Wang (:fredw) 2018-09-05 07:14:25 PDT 
Created attachment 348916 [details]
Patch

Rebasing...
Comment 8 Simon Fraser (smfr) 2018-09-05 11:10:19 PDT 
I kinda wonder if we should just change it and deal with the fallout. I fear that the "deprecated" version of the function will never go away.
Comment 9 Frédéric Wang (:fredw) 2018-09-05 11:36:11 PDT 
(In reply to Simon Fraser (smfr) from comment #8)
> I kinda wonder if we should just change it and deal with the fallout. I fear
> that the "deprecated" version of the function will never go away.

I guess this comment applies to bug 182785 too?