Bug 184302 - Start migration to a version of contentsToRootView() that may take scroll offset into account for delegated scrolling
Summary: Start migration to a version of contentsToRootView() that may take scroll off...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks: 184297
  Show dependency treegraph
 
Reported: 2018-04-04 07:33 PDT by Frédéric Wang (:fredw)
Modified: 2018-09-24 02:12 PDT (History)
2 users (show)

See Also:


Attachments
Patch for EWS (24.73 KB, patch)
2018-04-04 07:33 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.11 MB, application/zip)
2018-04-04 10:58 PDT, Build Bot
no flags Details
Patch (29.48 KB, patch)
2018-04-04 12:05 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (471.38 KB, patch)
2018-04-05 01:48 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (29.78 KB, patch)
2018-07-11 06:40 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (29.70 KB, patch)
2018-09-05 07:14 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-04-04 07:33:27 PDT
Created attachment 337167 [details]
Patch for EWS

This is similar to bug 182785 but to prepare for bug 184297.
Comment 1 Build Bot 2018-04-04 10:57:55 PDT
Comment on attachment 337167 [details]
Patch for EWS

Attachment 337167 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7205354

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 2 Build Bot 2018-04-04 10:58:06 PDT
Created attachment 337192 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 3 Frédéric Wang (:fredw) 2018-04-04 12:05:45 PDT
Created attachment 337200 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2018-04-05 01:48:47 PDT
Created attachment 337258 [details]
Patch
Comment 5 Frédéric Wang (:fredw) 2018-04-05 01:51:58 PDT
Comment on attachment 337258 [details]
Patch

Wrong bug.
Comment 6 Frédéric Wang (:fredw) 2018-07-11 06:40:49 PDT
Created attachment 344763 [details]
Patch

Rebasing...
Comment 7 Frédéric Wang (:fredw) 2018-09-05 07:14:25 PDT
Created attachment 348916 [details]
Patch

Rebasing...
Comment 8 Simon Fraser (smfr) 2018-09-05 11:10:19 PDT
I kinda wonder if we should just change it and deal with the fallout. I fear that the "deprecated" version of the function will never go away.
Comment 9 Frédéric Wang (:fredw) 2018-09-05 11:36:11 PDT
(In reply to Simon Fraser (smfr) from comment #8)
> I kinda wonder if we should just change it and deal with the fallout. I fear
> that the "deprecated" version of the function will never go away.

I guess this comment applies to bug 182785 too?