Bug 182785 - Start migration to a version of windowToContents() that may take scroll offset into account for delegated scrolling
Summary: Start migration to a version of windowToContents() that may take scroll offse...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks: 173833
  Show dependency treegraph
 
Reported: 2018-02-14 03:10 PST by Frédéric Wang (:fredw)
Modified: 2019-03-11 17:51 PDT (History)
5 users (show)

See Also:


Attachments
Patch for EWS (26.01 KB, patch)
2018-02-14 03:13 PST, Frédéric Wang (:fredw)
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (8.24 MB, application/zip)
2018-02-14 04:55 PST, Build Bot
no flags Details
Patch for EWS (38.67 KB, patch)
2018-02-15 04:13 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.08 MB, application/zip)
2018-02-15 05:28 PST, Build Bot
no flags Details
Archive of layout-test-results from ews200 for win-future (11.76 MB, application/zip)
2018-02-15 06:02 PST, Build Bot
no flags Details
Patch (46.12 KB, patch)
2018-02-15 07:33 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (40.70 KB, patch)
2018-02-16 01:25 PST, Frédéric Wang (:fredw)
simon.fraser: review+
Details | Formatted Diff | Diff
Patch (41.02 KB, patch)
2018-05-09 23:31 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (40.94 KB, patch)
2018-07-11 06:56 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (40.96 KB, patch)
2018-09-05 07:01 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-02-14 03:10:18 PST
.
Comment 1 Frédéric Wang (:fredw) 2018-02-14 03:13:58 PST
Created attachment 333781 [details]
Patch for EWS
Comment 2 Build Bot 2018-02-14 04:55:17 PST
Comment on attachment 333781 [details]
Patch for EWS

Attachment 333781 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6498801

New failing tests:
fast/visual-viewport/ios/stable-update-with-keyboard.html
fast/visual-viewport/ios/min-scale-greater-than-one.html
Comment 3 Build Bot 2018-02-14 04:55:19 PST
Created attachment 333787 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 4 Frédéric Wang (:fredw) 2018-02-15 04:13:14 PST
Created attachment 333890 [details]
Patch for EWS
Comment 5 Build Bot 2018-02-15 05:28:48 PST
Comment on attachment 333890 [details]
Patch for EWS

Attachment 333890 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6516042

New failing tests:
fast/events/mouse-cursor-image-set.html
fast/multicol/pagination/RightToLeft-rl-hittest.html
platform/mac/fast/events/content-inset-hit-testing.html
fast/events/frame-scroll-fake-mouse-move.html
tiled-drawing/header-and-footer-hit-testing.html
svg/custom/getscreenctm-in-scrollable-svg-area.xhtml
fast/events/drag-select-when-zoomed-with-header.html
fast/events/input-image-scrolled-x-y.html
fast/dom/Window/window-xy-properties.html
fast/scrolling/rtl-scrollbars-text-selection-scrolled.html
fast/events/mouse-cursor.html
tiled-drawing/header-and-footer-hit-testing-with-page-scale.html
fast/multicol/pagination/LeftToRight-tb-hittest.html
fast/events/anchor-image-scrolled-x-y.html
Comment 6 Build Bot 2018-02-15 05:28:49 PST
Created attachment 333891 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Build Bot 2018-02-15 06:01:54 PST
Comment on attachment 333890 [details]
Patch for EWS

Attachment 333890 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6516160

New failing tests:
fast/events/mouse-cursor-image-set.html
svg/custom/getscreenctm-in-scrollable-svg-area.xhtml
fast/events/input-image-scrolled-x-y.html
fast/dom/Window/window-xy-properties.html
fast/events/mouse-cursor.html
fast/multicol/pagination/LeftToRight-tb-hittest.html
fast/events/anchor-image-scrolled-x-y.html
Comment 8 Build Bot 2018-02-15 06:02:05 PST
Created attachment 333896 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 Frédéric Wang (:fredw) 2018-02-15 07:33:10 PST
Created attachment 333900 [details]
Patch
Comment 10 Frédéric Wang (:fredw) 2018-02-16 01:25:59 PST
Created attachment 334024 [details]
Patch
Comment 11 Simon Fraser (smfr) 2018-02-16 11:47:25 PST
I think the bug title should be something like "start migration to a version of windowToContents() that takes scroll offset into account when scrolling is delegated".
Comment 12 Simon Fraser (smfr) 2018-04-09 06:59:33 PDT
Comment on attachment 334024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334024&action=review

> Source/WebCore/platform/ScrollView.h:298
> -    WEBCORE_EXPORT IntPoint windowToContents(const IntPoint&) const;
> +    WEBCORE_EXPORT IntPoint deprecatedWindowToContents(const IntPoint&) const;

This needs a comments saying why deprecatedWindowToContents() exists.

I think you should also add back windowToContents() without the delegatesScrolling check in this or a followup commit.
Comment 13 Frédéric Wang (:fredw) 2018-04-09 08:02:12 PDT
Comment on attachment 334024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334024&action=review

>> Source/WebCore/platform/ScrollView.h:298
>> +    WEBCORE_EXPORT IntPoint deprecatedWindowToContents(const IntPoint&) const;
> 
> This needs a comments saying why deprecatedWindowToContents() exists.
> 
> I think you should also add back windowToContents() without the delegatesScrolling check in this or a followup commit.

I think these are more or less already explained in the ChangeLog but I can add a comment here too. Bug 173833 is also mentioned and has a patch adding back the new windowToContents() (Alternatively, I could add it in the present bug too but the new version won't be used for now).
Comment 14 Frédéric Wang (:fredw) 2018-05-09 23:31:44 PDT
Created attachment 340069 [details]
Patch

Rebasing
Comment 15 Frédéric Wang (:fredw) 2018-07-11 06:56:55 PDT
Created attachment 344764 [details]
Patch

Rebasing...
Comment 16 Frédéric Wang (:fredw) 2018-09-05 07:01:00 PDT
Created attachment 348910 [details]
Patch

Rebasing...
Comment 17 Frédéric Wang (:fredw) 2018-09-24 02:12:51 PDT
Resolve per bug 184302 comment 8