Bug 184233

Summary: [Enchant] Clean up TextCheckerEnchant
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183738    
Bug Blocks:    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2018-04-02 05:49:25 PDT
Implementation can be improved a bit.
Attachments
Patch (16.20 KB, patch)
2018-04-02 05:57 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-04-02 05:57:47 PDT
Created attachment 336979 [details] Patch
Michael Catanzaro
Comment 2 2018-04-02 08:02:31 PDT
Comment on attachment 336979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336979&action=review Nice > Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43 > + if (!dictionary) > + return; Remember C++ guarantees this func is only called if the parameter is nonnull, so remove this.
Carlos Garcia Campos
Comment 3 2018-04-02 08:22:47 PDT
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 336979 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336979&action=review > > Nice > > > Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43 > > + if (!dictionary) > > + return; > > Remember C++ guarantees this func is only called if the parameter is > nonnull, so remove this. Ah, right!
Carlos Garcia Campos
Comment 4 2018-04-03 00:16:57 PDT
Committed r230198: <https://trac.webkit.org/changeset/230198>
Radar WebKit Bug Importer
Comment 5 2018-04-03 00:18:20 PDT
<rdar://problem/39133084>
Note You need to log in before you can comment on or make changes to this bug.