Bug 184190

Summary: WorkQueueWin: don't move rvalues
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Web Template FrameworkAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, jfbastien, mark.lam, ryanhaddad, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 184167    
Bug Blocks:    
Attachments:
Description Flags
patch none

JF Bastien
Reported 2018-03-30 13:05:11 PDT
As part of #184167 optional is now more frequently an rvalue reference, and moving its .value() is not a thing that should be done anymore.
Attachments
patch (2.04 KB, patch)
2018-03-30 13:07 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-30 13:05:41 PDT
<rdar://problem/39049850>
JF Bastien
Comment 2 2018-03-30 13:07:51 PDT
Created attachment 336883 [details] patch Fixes a Windows build failure (because the file is Windows specific).
Mark Lam
Comment 3 2018-03-30 13:09:08 PDT
Comment on attachment 336883 [details] patch r=me
WebKit Commit Bot
Comment 4 2018-03-30 13:47:03 PDT
Comment on attachment 336883 [details] patch Clearing flags on attachment: 336883 Committed r230116: <https://trac.webkit.org/changeset/230116>
WebKit Commit Bot
Comment 5 2018-03-30 13:47:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.