Bug 184167

Summary:

Remove CXX_REFERENCE_QUALIFIED_FUNCTIONS

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

Web Template Framework

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, jfbastien, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

184164, 184190

Attachments:

Description	Flags
patch	ysuzuki: review+, ysuzuki: commit-queue-
patch for landing	commit-queue: commit-queue-
patch for landing, rebased onto my other patch which touched WTFString.h	commit-queue: commit-queue-
patch	commit-queue: commit-queue-
patch	none

JF Bastien

Reported 2018-03-29 18:32:06 PDT

Remove COMPILER_SUPPORTS(CXX_REFERENCE_QUALIFIED_FUNCTIONS), it's supported by all compilers WebKit supports (it's a C++11 feature, *detection* of it with __has_extension was added to clang on May 13th 2011, and VS2015 / GCC support it).

Attachments
patch (5.39 KB, patch) 2018-03-29 18:35 PDT, JF Bastien	ysuzuki: review+ ysuzuki: commit-queue-	Details Formatted Diff Diff
patch for landing (9.21 KB, patch) 2018-03-29 20:38 PDT, JF Bastien	commit-queue: commit-queue-	Details Formatted Diff Diff
patch for landing, rebased onto my other patch which touched WTFString.h (9.23 KB, patch) 2018-03-29 20:45 PDT, JF Bastien	commit-queue: commit-queue-	Details Formatted Diff Diff
patch (10.27 KB, patch) 2018-03-30 11:00 PDT, JF Bastien	commit-queue: commit-queue-	Details Formatted Diff Diff
patch (18.63 KB, patch) 2018-03-30 11:39 PDT, JF Bastien	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-03-29 18:33:42 PDT

<rdar://problem/39023130>

JF Bastien

Comment 2 2018-03-29 18:35:03 PDT

Created attachment 336829 [details] patch

Yusuke Suzuki

Comment 3 2018-03-29 20:10:49 PDT

Comment on attachment 336829 [details] patch Let's enable Optional.h's OPTIONAL_HAS_MOVE_ACCESSORS too!

JF Bastien

Comment 4 2018-03-29 20:38:58 PDT

Created attachment 336837 [details] patch for landing

WebKit Commit Bot

Comment 5 2018-03-29 20:40:28 PDT

Comment on attachment 336837 [details] patch for landing Rejecting attachment 336837 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 336837, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: d at 1 with fuzz 3. patching file Source/WTF/wtf/Compiler.h patching file Source/WTF/wtf/Optional.h patching file Source/WTF/wtf/Ref.h patching file Source/WTF/wtf/RefPtr.h patching file Source/WTF/wtf/text/WTFString.cpp patching file Source/WTF/wtf/text/WTFString.h Hunk #1 FAILED at 299. 1 out of 1 hunk FAILED -- saving rejects to file Source/WTF/wtf/text/WTFString.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7143574

JF Bastien

Comment 6 2018-03-29 20:45:35 PDT

Created attachment 336838 [details] patch for landing, rebased onto my other patch which touched WTFString.h

WebKit Commit Bot

Comment 7 2018-03-29 21:17:07 PDT

Comment on attachment 336838 [details] patch for landing, rebased onto my other patch which touched WTFString.h Rejecting attachment 336838 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: urces/UnifiedSource15.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource15.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource2.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource2.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/7143638

JF Bastien

Comment 8 2018-03-29 21:19:47 PDT

Interesting, the change makes some things rvalue references instead of lvalues, which causes some static asserts. Will fix tomorrow.

JF Bastien

Comment 9 2018-03-30 11:00:58 PDT

Created attachment 336871 [details] patch

WebKit Commit Bot

Comment 10 2018-03-30 11:32:04 PDT

Comment on attachment 336871 [details] patch Rejecting attachment 336871 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: urces/UnifiedSource15.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource15.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource2.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource2.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/7149511

JF Bastien

Comment 11 2018-03-30 11:39:35 PDT

Created attachment 336874 [details] patch Fix more bad moves. My local build is borked, starting it from scratch so I'm not sure I got all of them yet...

WebKit Commit Bot

Comment 12 2018-03-30 12:17:00 PDT

Comment on attachment 336874 [details] patch Clearing flags on attachment: 336874 Committed r230113: <https://trac.webkit.org/changeset/230113>

WebKit Commit Bot

Comment 13 2018-03-30 12:17:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.