Bug 183937
| Summary: | Icon from Web App Manifest not supported | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Thomas Steiner <tomac> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED MOVED | ||
| Severity: | Normal | CC: | a, aarontgrogg, bfulgham, big.jan, cedric, cristian.stanescu, dev, guilhermezz, harit.subscriptions, hearcomestreble, hypertree, judahgabriel, juraj.malecka, kharchenkosviatoslav, mail, martiminchev, mathias, n.dj, nicolas, onderceylan, paul.neave, rik, rniwa, sander, splaktar, talk, timswinkels, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 11 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=158205 | ||
Thomas Steiner
Steps to reproduce:
1) Go to https://tomayac.github.io/pwa-feature-detector/
2) Add the app to the home screen
3) Experience the following issues:
- The app icon is not respected (120x120px).
Expected behavior:
- The app icon should be respected (120x120px should be OK).
- The icon (no matter if auto-generated or set in the manifest) should always be shown.
Mozilla/5.0 (iPhone; CPU iPhone OS 11_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.0 Mobile/15E148 Safari/604.1
Initially reported in https://bugs.webkit.org/show_bug.cgi?id=182261#add_comment.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/38885381>
Ryosuke Niwa
<rdar://problem/37585902>
Thomas Steiner
The latest Web App Manifest spec now supports icon masks: https://w3c.github.io/manifest/#icon-masks. (This via https://twitter.com/kennethrohde).
Harit Himanshu
Please prioritize this issue. Getting PWA consistently across all devices is very important to us as web developers. Thank you
Nathaniel Dassardo-Joseph
Agree with the above.
Standardising PWAs will align the web and mobile technologies.
Philipp
+1 Would be great to have this
aarontgrogg
Yes please!
Ernst
+1 It will be fantastic to have this.
Keysee
+1 Would be great!
Mathias Bynens
FWIW this is an issue for us on v8.dev, to the point where we're considering resorting to userland workarounds (https://github.com/GoogleChromeLabs/pwacompat) for this iOS Safari issue.
Jan
+1 Would be great!
Judah Gabriel Himango
+1, we web devs really want to see this supported.
Abdón Rodríguez Davila
+1 yes please!
onderceylan
The Web App Manifest API development on WebKit feature status is moved from "In Development" status to "Partially Supported": https://webkit.org/status/#?search=web%20app%20manifest
Is there any plan for the development of this feature?
Thomas Steiner
This has been implemented as of iOS 15.4 beta 1. Thanks so much! I noticed a small issue with the chosen icon, though. Filed as https://bugs.webkit.org/show_bug.cgi?id=235877.
Brent Fulgham
The fix for this issue was needed outside the WebKit project, therefore this is being resolved as 'Moved'.
This should now be fixed in STP 139, iOS 15.4 Beta, and macOS 12.3 Beta.
Thomas Steiner
Thanks for fixing this and also for stating where it has rolled out. Did you have a chance to reproduce the follow-up bug I have reported in https://bugs.webkit.org/show_bug.cgi?id=235877?