Bug 183738

Summary: [GTK] Segfaults in enchant_broker_free_dict()
Product: WebKit Reporter: Cédric Bellegarde <cedric.bellegarde>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, mcatanzaro
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184003
Bug Depends on:    
Bug Blocks: 184233    
Attachments:
Description Flags
Backtrace
none
Patch mcatanzaro: review+

Cédric Bellegarde
Reported 2018-03-19 01:39:31 PDT
Created attachment 336035 [details] Backtrace Fedora 28 / WebKitGTK 2.20
Attachments
Backtrace (10.33 KB, text/plain)
2018-03-19 01:39 PDT, Cédric Bellegarde 		no flags
Details
Patch (2.84 KB, patch)
2018-04-02 04:06 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-03-19 16:42:22 PDT
Are you able to reproduce this one in eolie, or was it random?
Carlos Garcia Campos
Comment 2 2018-04-02 04:04:38 PDT
My guess is that there aren't any dictionaries in the system and m_enchantDictionaries contains a single element that is nullptr, because enchant_broker_request_dict() can return NULL and we ar enot checking it.
Carlos Garcia Campos
Comment 3 2018-04-02 04:06:31 PDT
Created attachment 336977 [details] Patch
Cédric Bellegarde
Comment 4 2018-04-02 06:24:59 PDT
There are dictionnaries on the system but enchant_broker_request_dict() may have return null.
Michael Catanzaro
Comment 5 2018-04-02 07:45:39 PDT
Comment on attachment 336977 [details] Patch Good catch. This one had stumped me.
Carlos Garcia Campos
Comment 6 2018-04-03 00:11:15 PDT
Committed r230197: <https://trac.webkit.org/changeset/230197>
Note You need to log in before you can comment on or make changes to this bug.