Bug 183714

Summary: [iOS debug] Layout Test http/tests/storageAccess/grant-storage-access-under-opener.html is a flaky timeout
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: John Wilander <wilander>
Severity: Normal CC: commit-queue, jlewis3, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=183620
Description Flags
Patch for landing none

Description Ryan Haddad 2018-03-16 17:23:03 PDT
The following layout test is a flaky timeout on iOS Debug bots


Probable cause:

This test was added with https://trac.webkit.org/changeset/229597/webkit

Flakiness Dashboard:

Comment 1 Ryan Haddad 2018-03-20 09:25:54 PDT
Skipped test on iOS debug in https://trac.webkit.org/changeset/229760/webkit
Comment 2 Radar WebKit Bug Importer 2018-03-20 09:26:20 PDT
Comment 3 John Wilander 2018-05-30 15:55:15 PDT
Created attachment 341612 [details]
Patch for landing
Comment 4 John Wilander 2018-05-30 15:56:18 PDT
The patch just adds additional logging and turns the test back on for iOS Debug. With the new console log entries we might be able to figure out why the test is timing out.
Comment 5 WebKit Commit Bot 2018-05-30 16:34:18 PDT
Comment on attachment 341612 [details]
Patch for landing

Clearing flags on attachment: 341612

Committed r232317: <https://trac.webkit.org/changeset/232317>
Comment 6 WebKit Commit Bot 2018-05-30 16:34:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Ryan Haddad 2018-06-13 13:57:52 PDT

--- /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/http/tests/storageAccess/grant-storage-access-under-opener-expected.txt
+++ /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/http/tests/storageAccess/grant-storage-access-under-opener-actual.txt
@@ -1,22 +1,5 @@
 CONSOLE MESSAGE: line 54: Running test.
 CONSOLE MESSAGE: line 67: About to call testRunner.statisticsUpdateCookiePartitioning().
-CONSOLE MESSAGE: line 69: About to open the new window.
-CONSOLE MESSAGE: line 43: About to open the third party iframe.
-Tests that a cross-origin window from a prevalent domain with non-recent user interaction gets immediate storage access under its opener.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 63652)
+FAIL: Timed out waiting for notifyDone to be called
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS Cookie created.
-PASS successfullyParsed is true
-Frame: '<!--frame1-->'
-Should receive first-party cookie.
-Received cookie named 'firstPartyCookie'.
-Did not receive cookie named ''.
-Client-side document.cookie: firstPartyCookie=value
Comment 8 John Wilander 2018-06-13 13:59:17 PDT

It's testRunner.statisticsUpdateCookiePartitioning() that gets tripped up somehow. Will investigate.
Comment 9 John Wilander 2018-06-18 10:40:14 PDT
I'll make a related change in https://bugs.webkit.org/show_bug.cgi?id=186777.
Comment 10 Ryan Haddad 2018-06-21 10:42:11 PDT
It looks like this is still a flaky timeout (with no output) on iOS debug bots.
Comment 11 John Wilander 2018-06-21 11:07:43 PDT
No output is seriously messed up. :(
Comment 12 John Wilander 2018-06-21 17:25:09 PDT
Further work to address this is tracked in https://bugs.webkit.org/show_bug.cgi?id=186903.
Comment 13 Ryan Haddad 2018-07-10 09:15:44 PDT
This test has been consistently passing on iOS bots since 6/25, so this appears to be resolved.