Summary: | [iOS debug] Layout Test http/tests/storageAccess/grant-storage-access-under-opener.html is a flaky timeout | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | John Wilander <wilander> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, jlewis3, webkit-bug-importer, wilander | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=183620 https://bugs.webkit.org/show_bug.cgi?id=186777 https://bugs.webkit.org/show_bug.cgi?id=186903 |
||||||
Attachments: |
|
Description
Ryan Haddad
2018-03-16 17:23:03 PDT
Skipped test on iOS debug in https://trac.webkit.org/changeset/229760/webkit Created attachment 341612 [details]
Patch for landing
The patch just adds additional logging and turns the test back on for iOS Debug. With the new console log entries we might be able to figure out why the test is timing out. Comment on attachment 341612 [details] Patch for landing Clearing flags on attachment: 341612 Committed r232317: <https://trac.webkit.org/changeset/232317> All reviewed patches have been landed. Closing bug. https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r232798%20(4808)/results.html --- /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/http/tests/storageAccess/grant-storage-access-under-opener-expected.txt +++ /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/http/tests/storageAccess/grant-storage-access-under-opener-actual.txt @@ -1,22 +1,5 @@ CONSOLE MESSAGE: line 54: Running test. CONSOLE MESSAGE: line 67: About to call testRunner.statisticsUpdateCookiePartitioning(). -CONSOLE MESSAGE: line 69: About to open the new window. -CONSOLE MESSAGE: line 43: About to open the third party iframe. -Tests that a cross-origin window from a prevalent domain with non-recent user interaction gets immediate storage access under its opener. +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 63652) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS Cookie created. -PASS successfullyParsed is true - -TEST COMPLETE - - --------- -Frame: '<!--frame1-->' --------- -Should receive first-party cookie. -Received cookie named 'firstPartyCookie'. -Did not receive cookie named ''. -Client-side document.cookie: firstPartyCookie=value Thanks! It's testRunner.statisticsUpdateCookiePartitioning() that gets tripped up somehow. Will investigate. I'll make a related change in https://bugs.webkit.org/show_bug.cgi?id=186777. It looks like this is still a flaky timeout (with no output) on iOS debug bots. No output is seriously messed up. :( Further work to address this is tracked in https://bugs.webkit.org/show_bug.cgi?id=186903. This test has been consistently passing on iOS bots since 6/25, so this appears to be resolved. |