Bug 186777 - Resource Load Statistics: Make sure to call callbacks even if there is no store (test infrastructure)
Summary: Resource Load Statistics: Make sure to call callbacks even if there is no sto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-18 10:35 PDT by John Wilander
Modified: 2018-06-19 00:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.93 KB, patch)
2018-06-18 10:57 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-06-18 10:35:48 PDT 
We have a couple of instances in WKWebsiteDataStoreRef.cpp where if there is no resource load statistics store we do an early return, like so: 
if (!store)
  return;

These instances need to also call the callback if there is one. Note that these functions are used for testing and this change is part of addressing test flakiness, for instance in https://bugs.webkit.org/show_bug.cgi?id=183714.
Comment 1 Radar WebKit Bug Importer 2018-06-18 10:53:29 PDT 
<rdar://problem/41216181>
Comment 2 John Wilander 2018-06-18 10:54:30 PDT 
(For any GTK people who get notified of this bug: I accidentally chose GTK instead of Misc. Sorry about that.)
Comment 3 John Wilander 2018-06-18 10:57:52 PDT 
Created attachment 342952 [details]
Patch
Comment 4 John Wilander 2018-06-18 15:00:17 PDT 
Comment on attachment 342952 [details]
Patch

Thanks, Chris!
Comment 5 WebKit Commit Bot 2018-06-18 15:27:04 PDT 
Comment on attachment 342952 [details]
Patch

Clearing flags on attachment: 342952

Committed r232950: <https://trac.webkit.org/changeset/232950>
Comment 6 WebKit Commit Bot 2018-06-18 15:27:06 PDT 
All reviewed patches have been landed.  Closing bug.