It turns out the fix in https://bugs.webkit.org/show_bug.cgi?id=183577 wasn't enough to address the compatibility issues with popups. Some of them just detect their unpartitioned cookies, auto-dismiss themselves, and expect their unpartitioned cookies to be available under the opener afterwards. We should grant them access if the popup's domain has had user interaction _previously_. Note that we still need the part in https://bugs.webkit.org/show_bug.cgi?id=183577 because if the popup's domain has not received user interaction previously, we will not grant it storage access on just the window open.
<rdar://problem/38431469>
Created attachment 335750 [details] Patch
Created attachment 335752 [details] Patch
Created attachment 335754 [details] Patch
Added test cases as [ Pass ] in expectations files.
Comment on attachment 335754 [details] Patch R=me
Comment on attachment 335754 [details] Patch Thanks, Brent!
Comment on attachment 335754 [details] Patch Clearing flags on attachment: 335754 Committed r229597: <https://trac.webkit.org/changeset/229597>
All reviewed patches have been landed. Closing bug.
This change seems to have caused storageAccess LayoutTest failures: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229601%20(3439)/results.html
(In reply to Ryan Haddad from comment #10) > This change seems to have caused storageAccess LayoutTest failures: > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229601%20(3439)/results.html It's probably the network process that keeps state between test runs. I'll try to come up with a fix.
I have a fix I'll put up for review. Thanks for letting me know, Ryan!
https://bugs.webkit.org/show_bug.cgi?id=183641 tracks the fix.