Bug 183504 – [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations

• Component: New Bugs
• Status: RESOLVED FIXED

[Antoine Quint]

[Web Animations] Implement CSS Animations and CSS Transitions over Web Animations

[Antoine Quint]

Created attachment 335407 [details]
Patch

[EWS Watchlist]

Attachment 335407 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:521:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:559:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 335407 [details]
Patch

Attachment 335407 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6874873

New failing tests:
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html
imported/w3c/web-platform-tests/css-timing-1/step-timing-functions-output.html
webanimations/animation-opacity-animation-crash.html
imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html
webanimations/opacity-animation-yields-compositing.html
imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html
imported/w3c/web-platform-tests/css/css-multicol/multicol-gap-animation-001.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html

[EWS Watchlist]

Created attachment 335414 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335407 [details]
Patch

Attachment 335407 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6874897

New failing tests:
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html
imported/w3c/web-platform-tests/css-timing-1/step-timing-functions-output.html
imported/w3c/web-platform-tests/css/css-multicol/multicol-gap-animation-001.html
imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html
webanimations/opacity-animation-yields-compositing.html
imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html
webanimations/animation-opacity-animation-crash.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html

[EWS Watchlist]

Created attachment 335415 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335407 [details]
Patch

Attachment 335407 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6874933

New failing tests:
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html
imported/w3c/web-platform-tests/css-timing-1/step-timing-functions-output.html
imported/w3c/web-platform-tests/css/css-multicol/multicol-gap-animation-001.html
imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html
webanimations/opacity-animation-yields-compositing.html
imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html

[EWS Watchlist]

Created attachment 335417 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335407 [details]
Patch

Attachment 335407 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6874966

New failing tests:
imported/w3c/web-platform-tests/css-timing-1/step-timing-functions-output.html
webanimations/animation-opacity-animation-crash.html
imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output.html
webanimations/opacity-animation-yields-compositing.html
imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html
imported/w3c/web-platform-tests/css/css-multicol/multicol-gap-animation-001.html

[EWS Watchlist]

Created attachment 335418 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 335558 [details]
Patch

[EWS Watchlist]

Attachment 335558 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:518:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:556:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antoine Quint]

Created attachment 335559 [details]
Patch

[EWS Watchlist]

Attachment 335559 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:518:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:556:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 335559 [details]
Patch

Attachment 335559 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6907849

New failing tests:
imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html
webanimations/css-animations.html

[EWS Watchlist]

Created attachment 335560 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335559 [details]
Patch

Attachment 335559 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6907954

New failing tests:
imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html
webanimations/css-animations.html

[EWS Watchlist]

Created attachment 335563 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335559 [details]
Patch

Attachment 335559 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6907961

New failing tests:
imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html
webanimations/css-animations.html

[EWS Watchlist]

Created attachment 335570 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 335573 [details]
Patch

[Antoine Quint]

This is a large patch, for reviewing please see webkit.org/b/183552, webkit.org/b/183553, webkit.org/b/183554, webkit.org/b/183555, webkit.org/b/183556, webkit.org/b/183557 and webkit.org/b/183558.

[EWS Watchlist]

Attachment 335573 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:518:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:556:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 335573 [details]
Patch

Attachment 335573 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6910004

New failing tests:
webanimations/css-animations.html

[EWS Watchlist]

Created attachment 335578 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335573 [details]
Patch

Attachment 335573 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6910075

New failing tests:
webanimations/css-animations.html

[EWS Watchlist]

Created attachment 335579 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335573 [details]
Patch

Attachment 335573 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6910016

New failing tests:
webanimations/css-animations.html

[EWS Watchlist]

Created attachment 335580 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335573 [details]
Patch

Attachment 335573 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6909992

New failing tests:
webanimations/css-animations.html

[EWS Watchlist]

Created attachment 335581 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 335584 [details]
Patch

[Antoine Quint]

Created attachment 335585 [details]
Patch

[EWS Watchlist]

Attachment 335585 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:518:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:556:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 335585 [details]
Patch

Attachment 335585 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6913220

New failing tests:
webanimations/css-animations.html
webanimations/css-transitions.html

[EWS Watchlist]

Created attachment 335586 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Antoine Quint]

Created attachment 335589 [details]
Patch

[EWS Watchlist]

Attachment 335589 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:518:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:556:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antoine Quint]

<rdar://problem/38372965>

[Antoine Quint]

Committed r229530: <https://trac.webkit.org/changeset/229530>

[Antoine Quint]

*** Bug 183558 has been marked as a duplicate of this bug. ***

[Antoine Quint]

*** Bug 183557 has been marked as a duplicate of this bug. ***

[Antoine Quint]

*** Bug 183556 has been marked as a duplicate of this bug. ***

[Antoine Quint]

*** Bug 183555 has been marked as a duplicate of this bug. ***

[Antoine Quint]

*** Bug 183554 has been marked as a duplicate of this bug. ***

[Antoine Quint]

*** Bug 183553 has been marked as a duplicate of this bug. ***

[Antoine Quint]

*** Bug 183552 has been marked as a duplicate of this bug. ***