Bug 183554 – [Web Animations] Fix some WebAnimation lifecycle issues in preparation for declarative animations support

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Animations

[Antoine Quint]

[Web Animations] Fix some WebAnimation lifecycle issues in preparation for declarative animations support

[Antoine Quint]

Created attachment 335564 [details]
Patch

[Dean Jackson]

Comment on attachment 335564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335564&action=review

> Source/WebCore/animation/WebAnimation.cpp:664
> +    MicrotaskQueue::mainThreadQueue().append(std::make_unique<VoidMicrotask>([this, protectedThis = makeRef(*this)] () {
> +        this->performMicrotask();
> +    }));

No need for the this in []. Just use protectedThis->performMicrotask()

[Antoine Quint]

(In reply to Dean Jackson from comment #2)
> Comment on attachment 335564 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335564&action=review
> 
> > Source/WebCore/animation/WebAnimation.cpp:664
> > +    MicrotaskQueue::mainThreadQueue().append(std::make_unique<VoidMicrotask>([this, protectedThis = makeRef(*this)] () {
> > +        this->performMicrotask();
> > +    }));
> 
> No need for the this in []. Just use protectedThis->performMicrotask()

It actually is needed, the compiler says "'this' cannot be implicitly captured in this context" otherwise.

[Antoine Quint]

*** This bug has been marked as a duplicate of bug 183504 ***