Bug 183556 – [Web Animations] Create keyframes for declarative animations based on backing Animation and RenderStyle objects

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Animations

[Antoine Quint]

[Web Animations] Create keyframes for declarative animations based on backing Animation and RenderStyle objects

[Antoine Quint]

Created attachment 335567 [details]
Patch

[EWS Watchlist]

Attachment 335567 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:512:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:550:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 335567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335567&action=review

> Source/WebCore/ChangeLog:9
> +        animations() and transitions() functions during style resolution. We add new methods on KeyframeEffectReadOnly to create blending keyframes, which

is blending keyframes a spec term? i'm not sure what it is supposed to mean

> Source/WebCore/ChangeLog:21
> +        looking up the keyframes date obtained from the @keyframes rule with this backing animation's name.

data

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:837
> +    return !m_blendingKeyframes.isEmpty();

return hasBlendingKeyframes()

[Antoine Quint]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 335567 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335567&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        animations() and transitions() functions during style resolution. We add new methods on KeyframeEffectReadOnly to create blending keyframes, which
> 
> is blending keyframes a spec term? i'm not sure what it is supposed to mean

It's not part of the spec. It's a term we've been using in our Web Animations implementation to distinguish between the keyframes parsed from the JS API, which are Vector<ParsedKeyframe> and contain raw unparsed values that can be roundtripped through getKeyframes() calls, and the keyframes used for blending, using CSSPropertyAnimation::blendProperties(), which are KeyframeList and pre-date the Web Animations code.

> > Source/WebCore/ChangeLog:21
> > +        looking up the keyframes date obtained from the @keyframes rule with this backing animation's name.
> 
> data

Will fix.

> > Source/WebCore/animation/KeyframeEffectReadOnly.cpp:837
> > +    return !m_blendingKeyframes.isEmpty();
> 
> return hasBlendingKeyframes()

That is much nicer, yes!

[Antoine Quint]

*** This bug has been marked as a duplicate of bug 183504 ***