| Summary: | Remove WebCookieManager and messaging from WebContent process. | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, beidson, bfulgham, bugs-noreply, clopez, commit-queue, ews-watchlist, mcatanzaro, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=183192 | ||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 183486, 183519 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Brent Fulgham
2018-03-06 13:19:59 PST
Created attachment 335163 [details]
Patch
Created attachment 335164 [details]
Patch
Created attachment 335166 [details]
Patch
Created attachment 335196 [details]
Patch
Comment on attachment 335196 [details]
Patch
r=me
don't break gtk
Comment on attachment 335196 [details] Patch Attachment 335196 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6841105 New failing tests: http/wpt/resource-timing/rt-initiatorType-media.html Created attachment 335199 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 335239 [details]
Patch
Created attachment 335298 [details]
Patch for landing
Comment on attachment 335298 [details] Patch for landing Rejecting attachment 335298 [details] from commit-queue. Number of test failures exceeded the failure limit. Full output: http://webkit-queues.webkit.org/results/6857355 Created attachment 335302 [details]
Archive of layout-test-results from webkit-cq-02 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to WebKit Commit Bot from comment #12) > Created attachment 335302 [details] > Archive of layout-test-results from webkit-cq-02 for mac-sierra > > The attached test failures were seen while running run-webkit-tests on the > commit-queue. > Bot: webkit-cq-02 Port: mac-sierra Platform: Mac OS X 10.12.6 These failures do not reproduce locally, and don't seem to be related to dormant cookie code in the WebContent process. Committed r229426: <https://trac.webkit.org/changeset/229426> (In reply to Brent Fulgham from comment #14) > Committed r229426: <https://trac.webkit.org/changeset/229426> It seems this has broken both GTK and WPE builds: https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/9314 (In reply to Carlos Alberto Lopez Perez from comment #15) > (In reply to Brent Fulgham from comment #14) > > Committed r229426: <https://trac.webkit.org/changeset/229426> > > It seems this has broken both GTK and WPE builds: > https://build.webkit.org/builders/WPE%20Linux%2064- > bit%20Release%20%28Build%29/builds/9314 Yes, I've been trying for two days on IRC to get a GTK person to take a look. Can anyone help fix the GTK build? WPE (and GTK) Failure looks like this: [668/857] Linking CXX executable bin/WPENetworkProcess FAILED: bin/WPENetworkProcess : && /usr/lib/ccache/c++ -fdiagnostics-color=always -Wno-attributes -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -O3 -DNDEBUG -L/home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/DependenciesWPE/Root/lib -fuse-ld=gold -Wl,--disable-new-dtags Source/WebKit/CMakeFiles/NetworkProcess.dir/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp.o -o bin/WPENetworkProcess -Wl,-rpath,/home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib: -rdynamic lib/libWPEWebKit.so.1.0.0 lib/libWebCore.a lib/libPAL.a lib/libJavaScriptCore.a lib/libWTF.a lib/libbmalloc.a -ldl ../DependenciesWPE/Root/lib/libWPEBackend.so && : lib/libWPEWebKit.so.1.0.0: error: undefined reference to 'non-virtual thunk to WebKit::WebCookieManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&)' lib/libWPEWebKit.so.1.0.0: error: undefined reference to 'WebKit::WebCookieManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&)' The WebCookieManager message handling doesn't seem to be getting generated, even though it appears in the CMakeLists.txt and SourcesWPE.txt/SourcesGTK.txt files. Committed r229442: <https://trac.webkit.org/changeset/229442> (In reply to Brent Fulgham from comment #16) > Yes, I've been trying for two days on IRC to get a GTK person to take a > look. Can anyone help fix the GTK build? Problem is that most of our team is only available on IRC during European business hours. I'm the exception, but I'm IP banned from freenode since I use a proxy service. Probably the easiest way to get our attention is to just leave a comment here on Bugzilla and CC us, either individually, or better our bugs-noreply@webkitgtk.org email. |