Bug 183369

Summary: Remove unused crash hook functionality
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Web Template FrameworkAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, mcatanzaro, rdemarest, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
Bug Depends on: 183379    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Michael Catanzaro
Reported 2018-03-06 08:28:24 PST
WTFSetCrashHook and WTFInstallReportBacktraceOnCrashHook are not used on any platforms
Attachments
Patch (3.43 KB, patch)
2018-03-06 08:29 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.40 KB, patch)
2018-04-12 11:17 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-03-06 08:29:36 PST
Created attachment 335099 [details] Patch
Michael Catanzaro
Comment 2 2018-03-06 11:11:01 PST
Committed r229330: <https://trac.webkit.org/changeset/229330>
Radar WebKit Bug Importer
Comment 3 2018-03-06 11:11:22 PST
<rdar://problem/38186660>
Alexey Proskuryakov
Comment 4 2018-03-06 12:48:49 PST
Turns out that these are still used by some Apple internal code. Filed rdar://problem/38190507 to remove the dependency, rolling back for now.
WebKit Commit Bot
Comment 5 2018-03-06 12:49:27 PST
Re-opened since this is blocked by bug 183379
Michael Catanzaro
Comment 6 2018-03-06 14:26:55 PST
Hardly a big deal, but I'm a bit surprised because the crash hook is only ever used in debug builds on Darwin. My guess is that something (Safari?) is installing a nonfunctional crash hook, perhaps? (Maybe we should consider renaming the *_EXPORT_PRIVATE macros, since they actually make the symbols public.)
Alexey Proskuryakov
Comment 7 2018-04-12 10:47:49 PDT
I think that this can be re-landed now.
Michael Catanzaro
Comment 8 2018-04-12 11:14:09 PDT
Okidokie then.
Michael Catanzaro
Comment 9 2018-04-12 11:17:17 PDT
Created attachment 337810 [details] Patch for landing
WebKit Commit Bot
Comment 10 2018-04-12 11:56:35 PDT
Comment on attachment 337810 [details] Patch for landing Clearing flags on attachment: 337810 Committed r230589: <https://trac.webkit.org/changeset/230589>
WebKit Commit Bot
Comment 11 2018-04-12 11:56:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.