Bug 183294

Summary: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html crashes with async policy delegates
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, ajuma, beidson, commit-queue, dbates, ews-watchlist, japhet, rniwa, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=182720
https://bugs.webkit.org/show_bug.cgi?id=184060
Bug Depends on:    
Bug Blocks: 180568    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews101 for mac-sierra
none
Patch
none
Archive of layout-test-results from webkit-cq-03 none

Chris Dumez
Reported 2018-03-02 10:43:23 PST
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html crashes with async policy delegates: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000620 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [0] VM Regions Near 0x620: --> __TEXT 0000000108567000-0000000108569000 [ 8K] r-x/rwx SM=COW /Volumes/VOLUME/*/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00000007631721dc WebCore::CachedResource::resourceToRevalidate() const + 12 (CachedResource.h:264) 1 com.apple.WebCore 0x000000076317454a WebCore::SubresourceLoader::willCancel(WebCore::ResourceError const&) + 314 (SubresourceLoader.cpp:687) 2 com.apple.WebCore 0x000000076315e451 WebCore::ResourceLoader::cancel(WebCore::ResourceError const&) + 161 (ResourceLoader.cpp:595) 3 com.apple.WebCore 0x00000007630a8ea8 WebCore::DocumentLoader::cancelMainResourceLoad(WebCore::ResourceError const&) + 184 (DocumentLoader.cpp:1769) 4 com.apple.WebCore 0x00000007630b42c2 WebCore::DocumentLoader::stopLoadingForPolicyChange() + 66 (DocumentLoader.cpp:931) 5 com.apple.WebCore 0x00000007630b4d46 WebCore::DocumentLoader::continueAfterContentPolicy(WebCore::PolicyAction) + 1318 (DocumentLoader.cpp:875) 6 com.apple.WebCore 0x00000007630da6d5 WebCore::DocumentLoader::responseReceived(WebCore::ResourceResponse const&)::$_7::operator()(WebCore::PolicyAction) const + 37 (DocumentLoader.cpp:791) 7 com.apple.WebCore 0x00000007630da57a WTF::Function<void (WebCore::PolicyAction)>::CallableWrapper<WebCore::DocumentLoader::responseReceived(WebCore::ResourceResponse const&)::$_7>::call(WebCore::PolicyAction) + 42 (Function.h:101) 8 com.apple.WebKit 0x0000000108702521 WTF::Function<void (WebCore::PolicyAction)>::operator()(WebCore::PolicyAction) const + 177 (Function.h:56) 9 com.apple.WebKit 0x0000000108e997e7 WebKit::WebFrame::didReceivePolicyDecision(unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID, std::optional<WebKit::WebsitePoliciesData>&&) + 423 (WebFrame.cpp:282) 10 com.apple.WebKit 0x0000000108fc605c WebKit::WebPage::didReceivePolicyDecision(unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID const&, std::optional<WebKit::WebsitePoliciesData>&&) + 156 (WebPage.cpp:2829) 11 com.apple.WebKit 0x000000010905b6f7 void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID const&, std::optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID, std::optional<WebKit::WebsitePoliciesData> >, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID const&, std::optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID, std::optional<WebKit::WebsitePoliciesData> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul>) + 439 (HandleMessage.h:41) 12 com.apple.WebKit 0x000000010905a760 void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID const&, std::optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID, std::optional<WebKit::WebsitePoliciesData> >, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul> >(std::__1::tuple<unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID, std::optional<WebKit::WebsitePoliciesData> >&&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID const&, std::optional<WebKit::WebsitePoliciesData>&&)) + 96 (HandleMessage.h:47) 13 com.apple.WebKit 0x0000000109048b7f void IPC::handleMessage<Messages::WebPage::DidReceivePolicyDecision, WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID const&, std::optional<WebKit::WebsitePoliciesData>&&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID const&, std::optional<WebKit::WebsitePoliciesData>&&)) + 383 (HandleMessage.h:127) 14 com.apple.WebKit 0x0000000109040572 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) + 5058 (WebPageMessageReceiver.cpp:673) 15 com.apple.WebKit 0x0000000108fcbe2e WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 510 (WebPage.cpp:3938) 16 com.apple.WebKit 0x0000000108fcbe74 non-virtual thunk to WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 52 17 com.apple.WebKit 0x00000001087d0ee8 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 456 (MessageReceiverMap.cpp:124) 18 com.apple.WebKit 0x00000001092137ad WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 61 (WebProcess.cpp:638) 19 com.apple.WebKit 0x00000001086c3963 IPC::Connection::dispatchMessage(IPC::Decoder&) + 51 (Connection.cpp:908) 20 com.apple.WebKit 0x00000001086b8f48 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 712 21 com.apple.WebKit 0x00000001086c3f6a IPC::Connection::dispatchOneMessage() + 1530 (Connection.cpp:965) 22 com.apple.WebKit 0x00000001086dc3fd IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() + 29 (Connection.cpp:902) 23 com.apple.WebKit 0x00000001086dc359 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() + 25 (Function.h:101) 24 com.apple.JavaScriptCore 0x000000077167c89b WTF::Function<void ()>::operator()() const + 139 (Function.h:56) 25 com.apple.JavaScriptCore 0x00000007716c18a3 WTF::RunLoop::performWork() + 211 (RunLoop.cpp:107) 26 com.apple.JavaScriptCore 0x00000007716c2144 WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38) 27 com.apple.CoreFoundation 0x00007fff4e1f2ca1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 28 com.apple.CoreFoundation 0x00007fff4e2ac69c __CFRunLoopDoSource0 + 108 29 com.apple.CoreFoundation 0x00007fff4e1d57e0 __CFRunLoopDoSources0 + 208 30 com.apple.CoreFoundation 0x00007fff4e1d4c5d __CFRunLoopRun + 1293 31 com.apple.CoreFoundation 0x00007fff4e1d44c3 CFRunLoopRunSpecific + 483 32 com.apple.HIToolbox 0x00007fff4d4bfd86 RunCurrentEventLoopInMode + 286 33 com.apple.HIToolbox 0x00007fff4d4bfaf6 ReceiveNextEventCommon + 613 34 com.apple.HIToolbox 0x00007fff4d4bf874 _BlockUntilNextEventMatchingListInModeWithFilter + 64 35 com.apple.AppKit 0x00007fff4b745c17 _DPSNextEvent + 2085 36 com.apple.AppKit 0x00007fff4bedbf04 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 37 com.apple.AppKit 0x00007fff4b73aa29 -[NSApplication run] + 764 38 com.apple.AppKit 0x00007fff4b709c02 NSApplicationMain + 804 39 libxpc.dylib 0x00007fff76ea9f93 _xpc_objc_main + 580 40 libxpc.dylib 0x00007fff76ea8be6 xpc_main + 417 41 com.apple.WebKit.WebContent 0x000000010856813b main + 1195 (XPCServiceMain.mm:148) 42 libdyld.dylib 0x00007fff76b5a015 start + 1
Attachments
Patch (7.61 KB, patch)
2018-03-02 12:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.25 MB, application/zip)
2018-03-02 14:00 PST, EWS Watchlist 		no flags
Details
Patch (14.84 KB, patch)
2018-03-02 14:19 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 (3.20 MB, application/zip)
2019-07-02 11:45 PDT, WebKit Commit Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-02 10:43:46 PST
<rdar://problem/38073596>
Chris Dumez
Comment 2 2018-03-02 12:56:31 PST
Created attachment 334918 [details] Patch
EWS Watchlist
Comment 3 2018-03-02 14:00:53 PST
Comment on attachment 334918 [details] Patch Attachment 334918 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6739915 New failing tests: http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate.html
EWS Watchlist
Comment 4 2018-03-02 14:00:55 PST
Created attachment 334926 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Chris Dumez
Comment 5 2018-03-02 14:19:52 PST
Created attachment 334928 [details] Patch
Chris Dumez
Comment 6 2018-03-02 14:20:50 PST
*** Bug 167380 has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 7 2018-03-02 14:21:26 PST
*** Bug 167376 has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 8 2018-03-02 14:22:17 PST
*** Bug 167211 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 9 2018-03-02 15:14:38 PST
Comment on attachment 334928 [details] Patch Clearing flags on attachment: 334928 Committed r229191: <https://trac.webkit.org/changeset/229191>
WebKit Commit Bot
Comment 10 2018-03-02 15:14:40 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 11 2019-07-02 11:45:55 PDT
The commit-queue just saw imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html flake (text diff, test timed out) while processing attachment 373339 [details] on bug 199365. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 12 2019-07-02 11:45:56 PDT
Created attachment 373345 [details] Archive of layout-test-results from webkit-cq-03
Note You need to log in before you can comment on or make changes to this bug.