Bug 183250
Summary: | wkbi is importing some bugs twice | ||
---|---|---|---|
Product: | WebKit | Reporter: | Lucas Forschler <lforschler> |
Component: | Tools / Tests | Assignee: | Lucas Forschler <lforschler> |
Status: | NEW | ||
Severity: | Normal | CC: | lforschler, webkit-bug-importer, wilander |
Priority: | P2 | Keywords: | InRadar |
Version: | Safari 11 | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Lucas Forschler
Using this as my tracking bug.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/38033914>
Lucas Forschler
This was duplicated:
https://bugs.webkit.org/show_bug.cgi?id=183218
https://bugs.webkit.org/show_bug.cgi?id=183249
Lucas Forschler
This bug wasn't duplicated.
Looking at logs of the other two... it appears we called migrate-bugs twice in a row. I'm not sure why.
Lucas Forschler
for 183218, here is what I think happened:
Looking at history:
wilander@apple.com 2018-02-28 11:09:25 PST CC webkit-bug-importer@group.apple.com
wilander@apple.com 2018-02-28 11:09:28 PST Assignee webkit-unassigned@lists.webkit.org wilander@apple.com
webkit-bug-importer@group.apple.com 2018-02-28 11:09:54 PST Keywords InRadar
see the importer was CC'd at 11:09:25 , and then another change was made to the bug (at 11:09:28) before the "InRadar" keyword made it back into Bugzilla (11:09:54).
Lucas Forschler
the same thing happened to 183249:
wilander@apple.com 2018-03-01 11:04:10 PST CC webkit-bug-importer@group.apple.com
wilander@apple.com 2018-03-01 11:04:19 PST Assignee webkit-unassigned@lists.webkit.org wilander@apple.com
webkit-bug-importer@group.apple.com 2018-03-01 11:04:38 PST Keywords InRadar
Lucas Forschler
It looks like there is a race condition. If a bug is modified after CC'ing the importer, but before we get the InRadar keyword, we span another update attempt.
Lucas Forschler
I'm not sure the best way to address this. We could consider a 'settle timer', to give bugzilla a chance to catch up before processing again.
John Wilander
I had a feeling it was some kind of race condition. I typically do it that way — CC the importer, then assign the bug to myself.