Bug 183160

Summary: Avoid scheduling a new build request when there are pending builds
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aakash_jain, ap, cdumez, dean_johnson, dewei_zhu, rniwa, slewis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175969    
Attachments:
Description Flags
Works around buildbot 0.9 limitation none

Ryosuke Niwa
Reported 2018-02-26 22:44:42 PST
For buildbot 0.9 compatibility, we shouldn't schedule a new build when there are pending build requests on a builder.
Attachments
Works around buildbot 0.9 limitation (4.18 KB, patch)
2018-02-26 22:52 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-02-26 22:52:06 PST
Created attachment 334673 [details] Works around buildbot 0.9 limitation
Aakash Jain
Comment 2 2018-02-27 08:23:28 PST
Comment on attachment 334673 [details] Works around buildbot 0.9 limitation Looks good. Thanks for the patch.
Aakash Jain
Comment 3 2018-02-27 19:16:45 PST
Please hold-off from committing it. This might not solve all the problem. We still need properties for pending build in order to get build-request-id. So, we might have to fix the root-cause of buildbot not providing us the properties. See https://bugs.webkit.org/show_bug.cgi?id=183194
Ryosuke Niwa
Comment 4 2018-02-28 01:47:02 PST
(In reply to Aakash Jain from comment #3) > Please hold-off from committing it. This might not solve all the problem. We > still need properties for pending build in order to get build-request-id. > So, we might have to fix the root-cause of buildbot not providing us the > properties. > > See https://bugs.webkit.org/show_bug.cgi?id=183194 Oh, that's a good point. Otherwise, we won't be able to update the perf dashboard when we've scheduled a build.
Aakash Jain
Comment 5 2018-03-04 10:02:55 PST
> So, we might have to fix the root-cause of buildbot not providing us the properties. Buildbot API now provides the properties for build-requests after the fix in https://github.com/buildbot/buildbot/pull/3976
Note You need to log in before you can comment on or make changes to this bug.