Bug 182996

Summary: [GStreamer] We need to adopt GstGlDisplays after GStreamer 1.13.1
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: WebCore Misc.Assignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, magomez, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
URL: https://bugzilla.gnome.org/show_bug.cgi?id=743062
Bug Depends on: 182968    
Bug Blocks:    
Attachments:
Description Flags
Patch calvaris: review+

Xabier Rodríguez Calvar
Reported 2018-02-21 01:31:25 PST
If you check https://bugzilla.gnome.org/show_bug.cgi?id=743062 you'll see like after 1.13.1, references are sinked and the GstGLDisplay object are really [transfer full] (before the docs say they were but they were [transfer floating]). We need to address this in runtime or we can crash or leak depending on the version.
Attachments
Patch (4.79 KB, patch)
2018-02-21 03:17 PST, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-02-21 03:17:18 PST
Created attachment 334358 [details] Patch
Philippe Normand
Comment 2 2018-02-21 05:25:52 PST
Committed r228869: <https://trac.webkit.org/changeset/228869>
Radar WebKit Bug Importer
Comment 3 2018-02-21 05:26:29 PST
<rdar://problem/37742438>
Note You need to log in before you can comment on or make changes to this bug.