| Summary: | Remove UTF-32 BOM parsing code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> |
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, japhet, kangil.han, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=179435 | ||
| Attachments: | |||
|
Description
Daniel Bates
2018-02-16 19:26:56 PST
Created attachment 334095 [details]
Patch
Please update failing tests accordingly. Clearly, it’s not quite dead code. Comment on attachment 334095 [details] Patch Attachment 334095 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6547182 New failing tests: imported/w3c/web-platform-tests/encoding/utf-32.html imported/w3c/web-platform-tests/encoding/unsupported-encodings.html Created attachment 334096 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 334095 [details] Patch Attachment 334095 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6547247 New failing tests: imported/w3c/web-platform-tests/encoding/utf-32.html imported/w3c/web-platform-tests/encoding/unsupported-encodings.html Created attachment 334098 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 334095 [details] Patch Attachment 334095 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6547208 New failing tests: imported/w3c/web-platform-tests/encoding/utf-32.html imported/w3c/web-platform-tests/encoding/unsupported-encodings.html Created attachment 334099 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Alexey Proskuryakov from comment #3) > Please update failing tests accordingly. Clearly, it’s not quite dead code. :) (In reply to Build Bot from comment #4) > Comment on attachment 334095 [details] > Patch > > Attachment 334095 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/6547182 > > New failing tests: > imported/w3c/web-platform-tests/encoding/utf-32.html > imported/w3c/web-platform-tests/encoding/unsupported-encodings.html Need to rebase these results. We now pass all subtests in these tests. Yay! Created attachment 334100 [details]
Patch for landing
Comment on attachment 334100 [details] Patch for landing Clearing flags on attachment: 334100 Committed r228594: <https://trac.webkit.org/changeset/228594> All reviewed patches have been landed. Closing bug. Support for UTF-32 BOM is not "dead code" so the bug name here was a bit misleading. Change was what we want, though. (In reply to Darin Adler from comment #15) > Support for UTF-32 BOM is not "dead code" so the bug name here was a bit > misleading. Change was what we want, though. You're right! Updated Bugzilla bug title and fixed up ChangeLog in <https://trac.webkit.org/changeset/228601> |