Bug 182900

Summary:

Remove UTF-32 BOM parsing code

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, japhet, kangil.han, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=179435

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews116 for mac-sierra	none
Patch for landing	none

Daniel Bates

Reported 2018-02-16 19:26:56 PST

Support for UTF-32 encodings were removed in the patch for bug #179435. We should also remove code that made use of these encodings.

Attachments
Patch (7.33 KB, patch) 2018-02-16 19:31 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.37 MB, application/zip) 2018-02-16 20:31 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.57 MB, application/zip) 2018-02-16 20:45 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.03 MB, application/zip) 2018-02-16 21:01 PST, EWS Watchlist	no flags	Details
Patch for landing (11.96 KB, patch) 2018-02-16 21:12 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-02-16 19:27:29 PST

<rdar://problem/37238717>

Daniel Bates

Comment 2 2018-02-16 19:31:56 PST

Created attachment 334095 [details] Patch

Alexey Proskuryakov

Comment 3 2018-02-16 20:20:35 PST

Please update failing tests accordingly. Clearly, it’s not quite dead code.

EWS Watchlist

Comment 4 2018-02-16 20:31:19 PST

Comment on attachment 334095 [details] Patch Attachment 334095 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6547182 New failing tests: imported/w3c/web-platform-tests/encoding/utf-32.html imported/w3c/web-platform-tests/encoding/unsupported-encodings.html

EWS Watchlist

Comment 5 2018-02-16 20:31:20 PST Comment hidden (obsolete)

Created attachment 334096 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-02-16 20:45:55 PST Comment hidden (obsolete)

Comment on attachment 334095 [details] Patch Attachment 334095 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6547247 New failing tests: imported/w3c/web-platform-tests/encoding/utf-32.html imported/w3c/web-platform-tests/encoding/unsupported-encodings.html

EWS Watchlist

Comment 7 2018-02-16 20:45:56 PST Comment hidden (obsolete)

Created attachment 334098 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-02-16 21:01:48 PST Comment hidden (obsolete)

Comment on attachment 334095 [details] Patch Attachment 334095 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6547208 New failing tests: imported/w3c/web-platform-tests/encoding/utf-32.html imported/w3c/web-platform-tests/encoding/unsupported-encodings.html

EWS Watchlist

Comment 9 2018-02-16 21:01:49 PST Comment hidden (obsolete)

Created attachment 334099 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

Daniel Bates

Comment 10 2018-02-16 21:04:32 PST

(In reply to Alexey Proskuryakov from comment #3) > Please update failing tests accordingly. Clearly, it’s not quite dead code. :)

Daniel Bates

Comment 11 2018-02-16 21:06:09 PST

(In reply to Build Bot from comment #4) > Comment on attachment 334095 [details] > Patch > > Attachment 334095 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/6547182 > > New failing tests: > imported/w3c/web-platform-tests/encoding/utf-32.html > imported/w3c/web-platform-tests/encoding/unsupported-encodings.html Need to rebase these results. We now pass all subtests in these tests. Yay!

Daniel Bates

Comment 12 2018-02-16 21:12:57 PST

Created attachment 334100 [details] Patch for landing

WebKit Commit Bot

Comment 13 2018-02-16 21:50:04 PST

Comment on attachment 334100 [details] Patch for landing Clearing flags on attachment: 334100 Committed r228594: <https://trac.webkit.org/changeset/228594>

WebKit Commit Bot

Comment 14 2018-02-16 21:50:05 PST

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 15 2018-02-17 14:37:27 PST

Support for UTF-32 BOM is not "dead code" so the bug name here was a bit misleading. Change was what we want, though.

Daniel Bates

Comment 16 2018-02-17 20:44:12 PST

(In reply to Darin Adler from comment #15) > Support for UTF-32 BOM is not "dead code" so the bug name here was a bit > misleading. Change was what we want, though. You're right! Updated Bugzilla bug title and fixed up ChangeLog in <https://trac.webkit.org/changeset/228601>

Note You need to log in before you can comment on or make changes to this bug.