Summary: | Start migration to a version of windowToContents() that may take scroll offset into account for delegated scrolling | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||||||||||
Component: | Frames | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||||||||||
Status: | RESOLVED WONTFIX | ||||||||||||||||||||||||
Severity: | Normal | CC: | ews-watchlist, fred.wang, rbuis, rniwa, simon.fraser | ||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=184302 https://bugs.webkit.org/show_bug.cgi?id=193649 |
||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||
Bug Blocks: | 173833 | ||||||||||||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2018-02-14 03:10:18 PST
Created attachment 333781 [details]
Patch for EWS
Comment on attachment 333781 [details] Patch for EWS Attachment 333781 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6498801 New failing tests: fast/visual-viewport/ios/stable-update-with-keyboard.html fast/visual-viewport/ios/min-scale-greater-than-one.html Created attachment 333787 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 333890 [details]
Patch for EWS
Comment on attachment 333890 [details] Patch for EWS Attachment 333890 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6516042 New failing tests: fast/events/mouse-cursor-image-set.html fast/multicol/pagination/RightToLeft-rl-hittest.html platform/mac/fast/events/content-inset-hit-testing.html fast/events/frame-scroll-fake-mouse-move.html tiled-drawing/header-and-footer-hit-testing.html svg/custom/getscreenctm-in-scrollable-svg-area.xhtml fast/events/drag-select-when-zoomed-with-header.html fast/events/input-image-scrolled-x-y.html fast/dom/Window/window-xy-properties.html fast/scrolling/rtl-scrollbars-text-selection-scrolled.html fast/events/mouse-cursor.html tiled-drawing/header-and-footer-hit-testing-with-page-scale.html fast/multicol/pagination/LeftToRight-tb-hittest.html fast/events/anchor-image-scrolled-x-y.html Created attachment 333891 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 333890 [details] Patch for EWS Attachment 333890 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6516160 New failing tests: fast/events/mouse-cursor-image-set.html svg/custom/getscreenctm-in-scrollable-svg-area.xhtml fast/events/input-image-scrolled-x-y.html fast/dom/Window/window-xy-properties.html fast/events/mouse-cursor.html fast/multicol/pagination/LeftToRight-tb-hittest.html fast/events/anchor-image-scrolled-x-y.html Created attachment 333896 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 333900 [details]
Patch
Created attachment 334024 [details]
Patch
I think the bug title should be something like "start migration to a version of windowToContents() that takes scroll offset into account when scrolling is delegated". Comment on attachment 334024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334024&action=review > Source/WebCore/platform/ScrollView.h:298 > - WEBCORE_EXPORT IntPoint windowToContents(const IntPoint&) const; > + WEBCORE_EXPORT IntPoint deprecatedWindowToContents(const IntPoint&) const; This needs a comments saying why deprecatedWindowToContents() exists. I think you should also add back windowToContents() without the delegatesScrolling check in this or a followup commit. Comment on attachment 334024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334024&action=review >> Source/WebCore/platform/ScrollView.h:298 >> + WEBCORE_EXPORT IntPoint deprecatedWindowToContents(const IntPoint&) const; > > This needs a comments saying why deprecatedWindowToContents() exists. > > I think you should also add back windowToContents() without the delegatesScrolling check in this or a followup commit. I think these are more or less already explained in the ChangeLog but I can add a comment here too. Bug 173833 is also mentioned and has a patch adding back the new windowToContents() (Alternatively, I could add it in the present bug too but the new version won't be used for now). Created attachment 340069 [details]
Patch
Rebasing
Created attachment 344764 [details]
Patch
Rebasing...
Created attachment 348910 [details]
Patch
Rebasing...
Resolve per bug 184302 comment 8 |