Summary: | [RenderTreeBuilder] Do not use RenderTreeBuilder::current() in RenderRubyRun::takeChild | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2018-02-08 10:07:31 PST
Created attachment 333384 [details]
Patch
Comment on attachment 333384 [details] Patch Rejecting attachment 333384 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 333384, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderRubyRun.cpp Hunk #1 FAILED at 110. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderRubyRun.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/6418483 Created attachment 333402 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 333402 [details]: media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html bug 182571 (authors: graouts@apple.com and ryanhaddad@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 333402 [details] Patch Clearing flags on attachment: 333402 Committed r228289: <https://trac.webkit.org/changeset/228289> All reviewed patches have been landed. Closing bug. |