Bug 182403

Summary: Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Follow-up fix none

youenn fablet
Reported 2018-02-01 12:55:34 PST
Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
Attachments
Patch (20.28 KB, patch)
2018-02-01 13:11 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (22.13 KB, patch)
2018-02-01 18:13 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Follow-up fix (1.82 KB, patch)
2018-02-02 15:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-02-01 12:58:27 PST
<rdar://problem/36673358>
youenn fablet
Comment 2 2018-02-01 13:11:46 PST
Created attachment 332902 [details] Patch
youenn fablet
Comment 3 2018-02-01 18:13:20 PST
Created attachment 332929 [details] Patch
Chris Dumez
Comment 4 2018-02-01 21:04:13 PST
It'd be good if Alex or Brady took a look at this one.
WebKit Commit Bot
Comment 5 2018-02-02 11:25:25 PST
Comment on attachment 332929 [details] Patch Clearing flags on attachment: 332929 Committed r228019: <https://trac.webkit.org/changeset/228019>
WebKit Commit Bot
Comment 6 2018-02-02 11:25:27 PST
All reviewed patches have been landed. Closing bug.
youenn fablet
Comment 7 2018-02-02 15:57:38 PST
Reopening to attach new patch.
youenn fablet
Comment 8 2018-02-02 15:57:38 PST
Created attachment 333014 [details] Follow-up fix
WebKit Commit Bot
Comment 9 2018-02-02 16:36:26 PST
Comment on attachment 333014 [details] Follow-up fix Clearing flags on attachment: 333014 Committed r228033: <https://trac.webkit.org/changeset/228033>
WebKit Commit Bot
Comment 10 2018-02-02 16:36:27 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 11 2018-02-05 14:38:04 PST
After this change, it seems all WebKitTestRunner instances share the same registration database direction, thus introducing flakiness :/
Chris Dumez
Comment 12 2018-02-05 14:48:30 PST
Comment on attachment 332929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332929&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:111 > + void setServiceWorkerRegistrationDirectory(String&& directory) { m_resolvedConfiguration.serviceWorkerRegistrationDirectory = WTFMove(directory); } WebsiteDataStore::resolveDirectoriesIfNecessary() overrides the path you set here in the resolvedConfiguration with the default path that is in the configuration :/
youenn fablet
Comment 13 2018-02-05 15:08:45 PST
(In reply to Chris Dumez from comment #12) > Comment on attachment 332929 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332929&action=review > > > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:111 > > + void setServiceWorkerRegistrationDirectory(String&& directory) { m_resolvedConfiguration.serviceWorkerRegistrationDirectory = WTFMove(directory); } > > WebsiteDataStore::resolveDirectoriesIfNecessary() overrides the path you set > here in the resolvedConfiguration with the default path that is in the > configuration :/ Filed https://bugs.webkit.org/show_bug.cgi?id=182514
Note You need to log in before you can comment on or make changes to this bug.