Bug 181495 – Bugzilla should load EWS bubbles in chronological order

• Component: Tools / Tests
• Status: RESOLVED DUPLICATE

[Aakash Jain]

Bugzilla takes a long time to display EWS bubbles when there are multiple attachments/patches. Bugzilla loads the EWS bubbles for the oldest patch first. For bugs with large number of patches (e.g.: 10+), this might results in long time (10+s) to load the EWS bubble for the most recent patch.

Bugzilla should load EWS bubbles in chronological order, so that the EWS bubbles for most recent patch is loaded first.

[Aakash Jain]

Created attachment 330957 [details]
Proposed patch

[Alexey Proskuryakov]

That's neat. Seems worth a heads up to webkit-dev, as this changes the order of attachments.

[Alexey Proskuryakov]

Comment on attachment 330957 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330957&action=review

> Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl:56
> +  [% FOREACH attachment = attachments.reverse %]

Need WEBKIT_CHANGES around this.

[Joseph Pecoraro]

This totally changes the order of attachments? I'm not sure that is what bugzilla users would expect. Comments are First -> Last so I'd also expect Attachments to be First -> Last.

[Joseph Pecoraro]

What about just not getting bubbles on obsolete patches?

> 152[%# if WEBKIT_CHANGES %]
> 153          [% IF attachment.ispatch %]
> 154          <div class="statusBubble">
> 155            <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
> 156                    style="width: 600px; height: 20px; border: none;" scrolling="no">
> 157            </iframe>
> 158          </div>
> 159          [% END %]
> 160[%# endif // WEBKIT_CHANGES %]


Changing:

-     [% IF attachment.ispatch %]
+     [% IF attachment.ispatch && !attachment.isobsolete %]

[Alexey Proskuryakov]

I frequently want to see complete history of EWS, even on obsoleted patches.

[Joseph Pecoraro]

(In reply to Alexey Proskuryakov from comment #6)
> I frequently want to see complete history of EWS, even on obsoleted patches.

You can make the attachment unobsolete in order to see that info.

[Joseph Pecoraro]

(In reply to Joseph Pecoraro from comment #7)
> (In reply to Alexey Proskuryakov from comment #6)
> > I frequently want to see complete history of EWS, even on obsoleted patches.
> 
> You can make the attachment unobsolete in order to see that info.

Or just viewing the Details page should show it, right?

[Joseph Pecoraro]

Is this bug a duplicate of bug 171157?
<https://webkit.org/b/171157> EWS Bubbles take a long time to show up - wasting time getting bubbles on obsolete, hidden, patches

[EWS Watchlist]

Comment on attachment 330957 [details]
Proposed patch

Attachment 330957 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6030294

New failing tests:
imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-video-bitrate.html

[EWS Watchlist]

Created attachment 331030 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Michael Catanzaro]

Comment on attachment 330957 [details]
Proposed patch

While this is clever, it's too heavy-handed IMO. This should be fixable without changing the attachment sort order.

I agree this is a largely dup of bug #171157.

[Michael Catanzaro]

*** This bug has been marked as a duplicate of bug 171157 ***