Bug 181378

Summary: libwebrtc: Fix 'ld: warning: cannot export hidden symbol' messages
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebRTCAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 177344    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2018-01-08 03:00:55 PST
When building libwebrtc using Release or Production configurations, 117 linker warnings like this occur: ld: warning: cannot export hidden symbol _WebRtcVad_ValidRateAndFrameLength from libwebrtc.build/Release-iphoneos/libwebrtc.build/Objects-normal/arm64/webrtc_vad.o This happens because the symbol isn't exported. These symbols should be removed from *.exp files.
Attachments
Patch v1 (12.68 KB, patch)
2018-01-08 03:02 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2018-01-08 03:02:29 PST
Created attachment 330673 [details] Patch v1
WebKit Commit Bot
Comment 2 2018-01-08 03:33:17 PST
Comment on attachment 330673 [details] Patch v1 Clearing flags on attachment: 330673 Committed r226506: <https://trac.webkit.org/changeset/226506>
WebKit Commit Bot
Comment 3 2018-01-08 03:33:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-01-08 03:41:36 PST
<rdar://problem/36346790>
Note You need to log in before you can comment on or make changes to this bug.