Bug 181201

Summary: [Attachment Support] Add plumbing for starting a drag with promised blob data
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, lforschler, mitz, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181332
Bug Depends on: 181189, 181190    
Bug Blocks: 181199, 181294    
Attachments:
Description Flags
Won't apply (see dependencies)
none
v2 (still blocked on dependencies)
none
v3 (rebased and modified)
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2017-12-31 19:19:53 PST
Work towards dragging attachments as files on macOS and iOS.
Attachments
Won't apply (see dependencies) (28.09 KB, patch)
2017-12-31 22:55 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
v2 (still blocked on dependencies) (44.69 KB, patch)
2018-01-01 17:27 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
v3 (rebased and modified) (40.36 KB, patch)
2018-01-02 23:50 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (40.28 KB, patch)
2018-01-03 20:10 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-12-31 22:55:59 PST
Created attachment 330281 [details] Won't apply (see dependencies)
Wenson Hsieh
Comment 2 2018-01-01 17:27:11 PST
Created attachment 330302 [details] v2 (still blocked on dependencies)
Wenson Hsieh
Comment 3 2018-01-02 23:50:51 PST
Created attachment 330368 [details] v3 (rebased and modified)
Tim Horton
Comment 4 2018-01-03 15:04:20 PST
Comment on attachment 330368 [details] v3 (rebased and modified) View in context: https://bugs.webkit.org/attachment.cgi?id=330368&action=review > Source/WebCore/page/DragClient.h:40 > +struct PromisedBlobData; Don’t need this anymore (in many places) > Source/WebKit/Scripts/webkit/messages.py:377 > + 'WebCore::PromisedBlobInfo': ['<WebCore/PromisedBlobInfo.h>'], Again, shouldn’t be needed.
Wenson Hsieh
Comment 5 2018-01-03 20:10:18 PST
Created attachment 330436 [details] Patch for landing
Wenson Hsieh
Comment 6 2018-01-03 20:10:27 PST
Comment on attachment 330368 [details] v3 (rebased and modified) View in context: https://bugs.webkit.org/attachment.cgi?id=330368&action=review >> Source/WebCore/page/DragClient.h:40 >> +struct PromisedBlobData; > > Don’t need this anymore (in many places) Removed! >> Source/WebKit/Scripts/webkit/messages.py:377 >> + 'WebCore::PromisedBlobInfo': ['<WebCore/PromisedBlobInfo.h>'], > > Again, shouldn’t be needed. Good catch — removed.
Wenson Hsieh
Comment 7 2018-01-03 21:51:39 PST
Comment on attachment 330436 [details] Patch for landing commit-queue is unresponsive again, but EWS is all green. I'm going to just land this.
Wenson Hsieh
Comment 8 2018-01-03 21:58:36 PST
Committed r226393: <https://trac.webkit.org/changeset/226393>.
Lucas Forschler
Comment 9 2018-01-04 05:31:42 PST
Did you notify anyone that commit queue was unresponsive?
Wenson Hsieh
Comment 10 2018-01-04 07:43:20 PST
(In reply to Lucas Forschler from comment #9) > Did you notify anyone that commit queue was unresponsive? No. Would you recommend that I notify you, Alexey, Dean Johnson, Aakash, or perhaps someone else?
Lucas Forschler
Comment 11 2018-01-04 12:52:54 PST
Any of those would work, or a bugzilla bug assigned to one of us would be even better. Thanks!
Radar WebKit Bug Importer
Comment 12 2018-01-04 12:58:16 PST
<rdar://problem/36303724>
Aakash Jain
Comment 13 2018-01-05 11:09:58 PST
(In reply to Lucas Forschler from comment #11) > Any of those would work, or a bugzilla bug assigned to one of us would be even better. Thanks! Tracked in https://bugs.webkit.org/show_bug.cgi?id=181332
Note You need to log in before you can comment on or make changes to this bug.