Summary: | Allow passing MessagePorts across processes (e.g. ServiceWorkers) | ||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||||||||||||||||||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | achristensen, aestes, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, rniwa, webkit-bug-importer | ||||||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||
Bug Depends on: | 181172, 181205, 181454, 181910 | ||||||||||||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Brady Eidson
2017-12-27 22:14:06 PST
Created attachment 330780 [details]
Super preliminary work
Super preliminary while I continue flushing out the test landscape
Created attachment 330781 [details]
Still early, now without unrelated cruft
Created attachment 330782 [details]
Still early, now without unrelated cruft
Attachment 330782 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 330829 [details]
Still early - Should apply?
Attachment 330829 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Build Bot from comment #6) > Attachment 330829 [details] did not pass style-queue: > > > ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61: Code inside a > namespace should not be indented. [whitespace/indent] [4] > Total errors found: 1 in 29 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. It's definitely wrong. Filed over here: https://bugs.webkit.org/show_bug.cgi?id=181441 Created attachment 330836 [details]
Fixed release build
Attachment 330836 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 331984 [details]
Patch
Created attachment 331993 [details]
Patch
This is definitely going to change the results of some imported SW web platform tests and I haven't tested such locally. Code changes of patch still in a reviewable state. Probably. Created attachment 331995 [details]
Patch
Created attachment 331996 [details]
Patch
*Lots* of test progressions in the w3c tests coming up. (In reply to Brady Eidson from comment #15) > *Lots* of test progressions in the w3c tests coming up. (But maybe some regressions) Comment on attachment 331996 [details] Patch Attachment 331996 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6177870 Number of test failures exceeded the failure limit. Created attachment 332002 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 331996 [details] Patch Attachment 331996 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6177905 Number of test failures exceeded the failure limit. Created attachment 332003 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 332006 [details]
Patch
Comment on attachment 332006 [details] Patch Attachment 332006 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6178744 New failing tests: fast/workers/worker-multi-port.html fast/dom/Window/window-postmessage-args.html fast/workers/worker-context-multi-port.html fast/events/message-port-multi.html Created attachment 332008 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 332009 [details]
Patch
Comment on attachment 332009 [details] Patch Attachment 332009 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6180290 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html Created attachment 332017 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 332032 [details]
Patch
Comment on attachment 332032 [details] Patch Clearing flags on attachment: 332032 Committed r227425: <https://trac.webkit.org/changeset/227425> All reviewed patches have been landed. Closing bug. *** Bug 178940 has been marked as a duplicate of this bug. *** |