Summary: | Identify MessagePorts by a globally unique MessagePortIdentifier | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, aestes, bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 181155 | ||||||||||
Bug Blocks: | 181178 | ||||||||||
Attachments: |
|
Description
Brady Eidson
2017-12-26 21:27:32 PST
Created attachment 330255 [details]
Patch
Comment on attachment 330255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330255&action=review > Source/WebCore/dom/MessagePortIdentifier.h:76 > + unsigned hashes[2]; > + hashes[0] = WTF::intHash(processIdentifier.toUInt64()); > + hashes[1] = WTF::intHash(portIdentifier.toUInt64()); > + > + return StringHasher::hashMemory(hashes, sizeof(hashes)); Could this use Darin's new computeHash? See https://bugs.webkit.org/show_bug.cgi?id=180318 Created attachment 330329 [details]
PFL
Comment on attachment 330329 [details] PFL Attachment 330329 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5895383 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html Created attachment 330332 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
(In reply to Build Bot from comment #4) > Comment on attachment 330329 [details] > PFL > > Attachment 330329 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/5895383 > > New failing tests: > imported/w3c/web-platform-tests/service-workers/service-worker/update-after- > navigation-fetch-event.https.html Hmmmmm not caused by this patch. Comment on attachment 330329 [details] PFL Clearing flags on attachment: 330329 Committed r226336: <https://trac.webkit.org/changeset/226336> |