Bug 181163

Summary:

REGRESSION(r226269): 60 JSC test failures on ARMv7

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, ossy, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

108645

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2017-12-26 09:06:31 PST

REGRESSION(r226269): 60 JSC test failures on ARMv7

Comment 1 Zan Dobersek 2017-12-26 09:12:09 PST

Created attachment 330197 [details]
Patch

Comment 2 Yusuke Suzuki 2017-12-26 09:17:49 PST

Comment on attachment 330197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330197&action=review

Oops, right. Thank you.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:4896
> +        JSValueRegsTemporary result(this);

Right. Previous code uses GPRTemporary, not GPRFlushedCallResult.

Comment 3 WebKit Commit Bot 2017-12-26 10:54:41 PST

Comment on attachment 330197 [details]
Patch

Clearing flags on attachment: 330197

Committed r226294: <https://trac.webkit.org/changeset/226294>

Comment 4 WebKit Commit Bot 2017-12-26 10:54:43 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-01-02 13:17:55 PST

<rdar://problem/36261348>