Bug 181004

Summary: [Meta][Win] Support ICU 59.1+
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, basuke, bfulgham, commit-queue, fujii.hironori, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195346
Bug Depends on: 180963    
Bug Blocks:    
Attachments:
Description Flags
WIP patch
none
Patch none

Don Olmstead
Reported 2017-12-19 15:20:37 PST
ICU 59 changed the value of UChar from wchar_t to char16_t. This causes a number of compilation issues when building on Windows. https://bugs.webkit.org/show_bug.cgi?id=172729 started the migration but it does not handle all cases for Windows ports.
Attachments
WIP patch (9.90 KB, patch)
2018-02-07 22:50 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2018-02-07 23:22 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-02-07 22:50:33 PST
Created attachment 333357 [details] WIP patch This is a half-baked WIP patch. We need a lot of conversions between UChar* and wchar_t*. I think this is a bad idea. wchar_t and char16_t has the identical internal representation in Windows. I think we should define -DUCHAR_TYPE=wchar_t for Windows port. http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac
Fujii Hironori
Comment 2 2018-02-07 23:22:46 PST
Created attachment 333359 [details] Patch
Don Olmstead
Comment 3 2018-02-08 12:12:11 PST
(In reply to Fujii Hironori from comment #2) > Created attachment 333359 [details] > Patch Does this require ICU to be compiled with that option as well?
Don Olmstead
Comment 4 2018-02-08 13:20:04 PST
(In reply to Don Olmstead from comment #3) > (In reply to Fujii Hironori from comment #2) > > Created attachment 333359 [details] > > Patch > > Does this require ICU to be compiled with that option as well? I'll cq+ it if you can confirm whether or not this is the case Fujii
Fujii Hironori
Comment 5 2018-02-08 17:05:58 PST
(In reply to Don Olmstead from comment #3) > Does this require ICU to be compiled with that option as well? No, it doesn't.
Don Olmstead
Comment 6 2018-02-08 17:32:29 PST
(In reply to Fujii Hironori from comment #5) > (In reply to Don Olmstead from comment #3) > > Does this require ICU to be compiled with that option as well? > > No, it doesn't. Ok cq+ on it. I still think we need to figure out what we should be doing for this though to actually fix it. I'm not sure that this will be available for an extended period of time.
WebKit Commit Bot
Comment 7 2018-02-08 17:58:28 PST
Comment on attachment 333359 [details] Patch Clearing flags on attachment: 333359 Committed r228305: <https://trac.webkit.org/changeset/228305>
WebKit Commit Bot
Comment 8 2018-02-08 17:58:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-02-08 17:59:28 PST
<rdar://problem/37374476>
Note You need to log in before you can comment on or make changes to this bug.