Summary: | [Meta][Win] Support ICU 59.1+ | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, annulen, Basuke.Suzuki, bfulgham, commit-queue, Hironori.Fujii, pvollan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=195346 | ||||||||
Bug Depends on: | 180963 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Don Olmstead
2017-12-19 15:20:37 PST
Created attachment 333357 [details] WIP patch This is a half-baked WIP patch. We need a lot of conversions between UChar* and wchar_t*. I think this is a bad idea. wchar_t and char16_t has the identical internal representation in Windows. I think we should define -DUCHAR_TYPE=wchar_t for Windows port. http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac Created attachment 333359 [details]
Patch
(In reply to Fujii Hironori from comment #2) > Created attachment 333359 [details] > Patch Does this require ICU to be compiled with that option as well? (In reply to Don Olmstead from comment #3) > (In reply to Fujii Hironori from comment #2) > > Created attachment 333359 [details] > > Patch > > Does this require ICU to be compiled with that option as well? I'll cq+ it if you can confirm whether or not this is the case Fujii (In reply to Don Olmstead from comment #3) > Does this require ICU to be compiled with that option as well? No, it doesn't. (In reply to Fujii Hironori from comment #5) > (In reply to Don Olmstead from comment #3) > > Does this require ICU to be compiled with that option as well? > > No, it doesn't. Ok cq+ on it. I still think we need to figure out what we should be doing for this though to actually fix it. I'm not sure that this will be available for an extended period of time. Comment on attachment 333359 [details] Patch Clearing flags on attachment: 333359 Committed r228305: <https://trac.webkit.org/changeset/228305> All reviewed patches have been landed. Closing bug. |