Bug 180963

Summary:

[Win] Use WCharStringExtras functions in WebCore

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

WebKit Misc.

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, commit-queue, darin, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181004

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Patch	none

Don Olmstead

Reported 2017-12-18 19:45:21 PST

Currently WinCairo cannot compile with ICU 59.1+ as it changed UChar to be char16_t. WCharStringExtras should be used to work around this. FileSystem related functionality has a lot of compile errors around this.

Attachments
Patch (30.49 KB, patch) 2017-12-19 15:57 PST, Don Olmstead	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (3.61 MB, application/zip) 2017-12-19 17:41 PST, EWS Watchlist	no flags	Details
Patch (30.57 KB, patch) 2017-12-19 18:51 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (30.56 KB, patch) 2017-12-19 20:13 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (30.57 KB, patch) 2017-12-19 20:27 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2017-12-18 19:48:28 PST

Have most of the things converted over to use WCharStringExtras. The thing I'm wondering is whether I should be using StringVectors or wchar_t[] when interacting with the Windows API. https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/win/FileSystemWin.cpp#L152 uses StringVector https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/win/FileSystemWin.cpp#L378 uses wchar_t Happy to modernize anything while hanging out in this file as well.

Don Olmstead

Comment 2 2017-12-19 15:21:56 PST

Changing to just fix instances where WCharStringExtras can be used in WebCore.

Don Olmstead

Comment 3 2017-12-19 15:57:06 PST

Created attachment 329848 [details] Patch Just uses whats in WCharStringExtras. WebCore does not totally compile but its a start of it.

EWS Watchlist

Comment 4 2017-12-19 17:14:33 PST

Attachment 329848 [details] did not pass style-queue: ERROR: Source/WebCore/platform/win/PasteboardWin.cpp:963: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:78: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 5 2017-12-19 17:41:35 PST

Comment on attachment 329848 [details] Patch Attachment 329848 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5762607 New failing tests: fast/mediastream/MediaStream-MediaElement-setObject-null.html

EWS Watchlist

Comment 6 2017-12-19 17:41:37 PST

Created attachment 329862 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Don Olmstead

Comment 7 2017-12-19 18:51:22 PST

Created attachment 329874 [details] Patch

EWS Watchlist

Comment 8 2017-12-19 19:02:19 PST

Attachment 329874 [details] did not pass style-queue: ERROR: Source/WebCore/platform/win/PasteboardWin.cpp:963: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 9 2017-12-19 20:13:42 PST

Created attachment 329885 [details] Patch Fix style

EWS Watchlist

Comment 10 2017-12-19 20:15:47 PST

Attachment 329885 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 11 2017-12-19 20:27:05 PST

Created attachment 329886 [details] Patch

WebKit Commit Bot

Comment 12 2017-12-20 17:10:55 PST

Comment on attachment 329886 [details] Patch Clearing flags on attachment: 329886 Committed r226205: <https://trac.webkit.org/changeset/226205>

WebKit Commit Bot

Comment 13 2017-12-20 17:10:57 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 14 2017-12-20 17:11:37 PST

<rdar://problem/36168339>

Note You need to log in before you can comment on or make changes to this bug.