Bug 180784

Summary: StorageProcess::deleteWebsiteData() should ensure there is a SWServer for the given sessionID
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180794
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2017-12-13 16:40:35 PST
StorageProcess::deleteWebsiteData() should ensure there is a SWServer for the given sessionID instead of not clearing anything when no such SWServer exists.
Comment 1 Chris Dumez 2017-12-13 16:42:13 PST
Created attachment 329284 [details]
Patch
Comment 2 Chris Dumez 2017-12-13 16:45:08 PST
Created attachment 329285 [details]
Patch
Comment 3 Chris Dumez 2017-12-14 09:03:46 PST
Work towards <rdar://problem/36034667>.
Comment 4 youenn fablet 2017-12-14 10:51:14 PST
Comment on attachment 329285 [details]
Patch

I guess we could try to write an API test for this one somehow. Probably need to require filling some service worker, hence the need for an HTTP server...
Comment 5 Chris Dumez 2017-12-14 10:52:37 PST
(In reply to youenn fablet from comment #4)
> Comment on attachment 329285 [details]
> Patch
> 
> I guess we could try to write an API test for this one somehow. Probably
> need to require filling some service worker, hence the need for an HTTP
> server...

I hear Brady is working on allowing API testing of Service Workers. Once his work lands, I'll look into testing this.
Comment 6 WebKit Commit Bot 2017-12-14 11:14:00 PST
Comment on attachment 329285 [details]
Patch

Clearing flags on attachment: 329285

Committed r225914: <https://trac.webkit.org/changeset/225914>
Comment 7 WebKit Commit Bot 2017-12-14 11:14:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-14 11:14:32 PST
<rdar://problem/36052966>