Bug 180608

Summary: [WPE] Add API version to library soname and pkg-config files
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WPE WebKitAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, commit-queue, mcatanzaro, zan
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 178894, 179915    
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-12-08 14:32:37 PST
Add API version to library soname and pkg-config files
Attachments
Patch (2.56 KB, patch)
2017-12-08 14:33 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-12-08 14:33:36 PST
Created attachment 328871 [details] Patch
Michael Catanzaro
Comment 2 2017-12-08 14:37:18 PST
(No r? because it's not properly tested yet.)
Michael Catanzaro
Comment 3 2018-02-15 10:53:44 PST
* The include directory for public headers is already versioned * I don't think the libexecdir for installed processes is versioned, need to confirm and fix
Michael Catanzaro
Comment 4 2018-04-06 16:37:50 PDT
(In reply to Michael Catanzaro from comment #3) > * I don't think the libexecdir for installed processes is versioned, need to > confirm and fix Even better, the secondary processes are being installed into /usr/bin... I'll handle that in a separate bug.
WebKit Commit Bot
Comment 5 2018-04-09 13:03:54 PDT
Comment on attachment 328871 [details] Patch Clearing flags on attachment: 328871 Committed r230449: <https://trac.webkit.org/changeset/230449>
WebKit Commit Bot
Comment 6 2018-04-09 13:03:56 PDT
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 7 2018-04-11 06:26:54 PDT
(In reply to WebKit Commit Bot from comment #5) > Comment on attachment 328871 [details] > Patch > > Clearing flags on attachment: 328871 > > Committed r230449: <https://trac.webkit.org/changeset/230449> This broke the run-minibrowser script for wpe. Hope we can improve testing things in the future. A fix for this is already in bug 184357
Note You need to log in before you can comment on or make changes to this bug.