Bug 180466

Summary: Web Inspector: REGRESSION(r225569): CSSStyleDetailsSidebarPanel no longer exists
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 174229, 178331    
Bug Blocks: 180467    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2017-12-06 00:12:28 PST
r225547 (<https://webkit.org/b/174229> Web Inspector: Styles: make Computed a top-level sidebar tab) renamed CSSStyleDetailsSidebarPanel to GeneralStyleDetailsSidebarPanel. I didn't notice this when I committed r225569 (<https://webkit.org/b/178331> Web Inspector: [PARITY] Styles Redesign: Make filtering work). Sorry 😅
Attachments
Patch (6.69 KB, patch)
2017-12-06 00:14 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (6.60 KB, patch)
2017-12-06 00:55 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-12-06 00:14:59 PST
Created attachment 328555 [details] Patch
Devin Rousso
Comment 2 2017-12-06 00:55:59 PST
Created attachment 328558 [details] Patch Rebase for additional changes
Joseph Pecoraro
Comment 3 2017-12-06 10:18:49 PST
Comment on attachment 328558 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2017-12-06 10:58:44 PST
Comment on attachment 328558 [details] Patch Clearing flags on attachment: 328558 Committed r225580: <https://trac.webkit.org/changeset/225580>
WebKit Commit Bot
Comment 5 2017-12-06 10:58:46 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-12-06 16:22:35 PST
<rdar://problem/35895854>
Radar WebKit Bug Importer
Comment 7 2017-12-06 16:22:36 PST
<rdar://problem/35895855>
Note You need to log in before you can comment on or make changes to this bug.