Summary: | REGRESSION(r221931): Row stretch doesn't work for grid container with min-height | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, darin, ews-watchlist, jfernandez, rego, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=773625 | ||||||||||||||
Bug Depends on: | 180345 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Javier Fernandez
2017-12-01 15:12:04 PST
Created attachment 328638 [details]
Patch
Attachment 328638 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:941: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 328643 [details]
Patch
Created attachment 328647 [details]
Patch
Comment on attachment 328647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328647&action=review > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:944 > + ASSERT(m_algorithm.freeSpace(direction())); > + return m_algorithm.freeSpace(direction()).value(); This assertion isn’t needed. Our version of std::optional::value includes an assertion. Comment on attachment 328647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328647&action=review Thanks for the review. >> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:944 >> + return m_algorithm.freeSpace(direction()).value(); > > This assertion isn’t needed. Our version of std::optional::value includes an assertion. Ok, removed it. Created attachment 328949 [details]
Patch for landing
Comment on attachment 328949 [details] Patch for landing Clearing flags on attachment: 328949 Committed r225741: <https://trac.webkit.org/changeset/225741> All reviewed patches have been landed. Closing bug. |