Bug 180153

Summary:

[Attachment Support] Implement SPI for clients to make an attachment element display in-place

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jlewis3, mitz, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
First pass	none
Split out AttachmentDisplayOptions into AttachmentTypes.h	none

Description Wenson Hsieh 2017-11-29 11:06:57 PST

<rdar://problem/35735252>

Comment 1 Wenson Hsieh 2017-11-29 11:54:38 PST

Created attachment 327882 [details]
First pass

Comment 2 Wenson Hsieh 2017-11-29 12:45:01 PST

Created attachment 327888 [details]
Split out AttachmentDisplayOptions into AttachmentTypes.h

Comment 3 WebKit Commit Bot 2017-11-29 18:23:48 PST

Comment on attachment 327888 [details]
Split out AttachmentDisplayOptions into AttachmentTypes.h

Clearing flags on attachment: 327888

Committed r225311: <https://trac.webkit.org/changeset/225311>

Comment 4 WebKit Commit Bot 2017-11-29 18:23:49 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Matt Lewis 2017-11-30 08:44:58 PST

This caused an API timeout with the API test:
WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode

on all macOS platforms.

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1440/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1440

Comment 6 Wenson Hsieh 2017-11-30 09:20:00 PST

Tracking a fix for the API test in <https://bugs.webkit.org/show_bug.cgi?id=180200>.