Bug 180153

Summary: [Attachment Support] Implement SPI for clients to make an attachment element display in-place
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, mitz, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First pass
none
Split out AttachmentDisplayOptions into AttachmentTypes.h none

Wenson Hsieh
Reported 2017-11-29 11:06:57 PST
<rdar://problem/35735252>
Attachments
First pass (44.57 KB, patch)
2017-11-29 11:54 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Split out AttachmentDisplayOptions into AttachmentTypes.h (50.45 KB, patch)
2017-11-29 12:45 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-11-29 11:54:38 PST
Created attachment 327882 [details] First pass
Wenson Hsieh
Comment 2 2017-11-29 12:45:01 PST
Created attachment 327888 [details] Split out AttachmentDisplayOptions into AttachmentTypes.h
WebKit Commit Bot
Comment 3 2017-11-29 18:23:48 PST
Comment on attachment 327888 [details] Split out AttachmentDisplayOptions into AttachmentTypes.h Clearing flags on attachment: 327888 Committed r225311: <https://trac.webkit.org/changeset/225311>
WebKit Commit Bot
Comment 4 2017-11-29 18:23:49 PST
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 5 2017-11-30 08:44:58 PST
This caused an API timeout with the API test: WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode on all macOS platforms. https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1440/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1440
Wenson Hsieh
Comment 6 2017-11-30 09:20:00 PST
Tracking a fix for the API test in <https://bugs.webkit.org/show_bug.cgi?id=180200>.
Note You need to log in before you can comment on or make changes to this bug.